Fix smart-home async observation gap - #78
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## beta #78 +/- ##
==========================================
+ Coverage 90.12% 90.26% +0.13%
==========================================
Files 32 32
Lines 1540 1571 +31
Branches 436 446 +10
==========================================
+ Hits 1388 1418 +30
- Misses 142 143 +1
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
transitionScenebehavior to the smart-home example sorun()acknowledges a pending view whileobserve()receives the settled event/view later.Verification
pnpm --dir examples/agents/smart-home testpnpm run test:scriptspnpm run test:examples -- --require-covered-packages-match-discovered --covers-package examples/adapters/mobx --covers-package examples/adapters/redux --covers-package examples/adapters/xstate --covers-package examples/agents/smart-home --covers-package examples/apps/form-with-validation --covers-package examples/apps/spa-router.fas/scripts/verify.sh --fullfas closeout-refreshcoderabbit review --agent -t committed --base beta -c AGENTS.mdraised 1 issue; verified as a false positive because framework examples have no runtime test files and are not discovered byscripts/test-examples.mjs --list.Notes