Skip to content

Fix smart-home async observation gap - #78

Merged
0xjcf merged 3 commits into
betafrom
fas/smart-home-async-observation-gap
Jun 30, 2026
Merged

Fix smart-home async observation gap#78
0xjcf merged 3 commits into
betafrom
fas/smart-home-async-observation-gap

Conversation

@0xjcf

@0xjcf 0xjcf commented Jun 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add delayed transitionScene behavior to the smart-home example so run() acknowledges a pending view while observe() receives the settled event/view later.
  • Cover commands during the pending transition and repeated transition requests so the state machine does not silently drop work while settling.
  • Keep top-level examples outside the pnpm workspace while making the examples runtime lane explicit and FAS-visible with an exact covered-package sync check.

Verification

  • pnpm --dir examples/agents/smart-home test
  • pnpm run test:scripts
  • pnpm run test:examples -- --require-covered-packages-match-discovered --covers-package examples/adapters/mobx --covers-package examples/adapters/redux --covers-package examples/adapters/xstate --covers-package examples/agents/smart-home --covers-package examples/apps/form-with-validation --covers-package examples/apps/spa-router
  • .fas/scripts/verify.sh --full
  • fas closeout-refresh
  • coderabbit review --agent -t committed --base beta -c AGENTS.md raised 1 issue; verified as a false positive because framework examples have no runtime test files and are not discovered by scripts/test-examples.mjs --list.

Notes

  • Closeout readiness has 0 failures. Remaining warnings are nonblocking memory/context enrichment and stale TDD red-receipt evidence.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0864e5ec-84e7-44a0-9dd6-b6512555bf0d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fas/smart-home-async-observation-gap

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.26%. Comparing base (f6a7a75) to head (a832a72).
⚠️ Report is 2 commits behind head on beta.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             beta      #78      +/-   ##
==========================================
+ Coverage   90.12%   90.26%   +0.13%     
==========================================
  Files          32       32              
  Lines        1540     1571      +31     
  Branches      436      446      +10     
==========================================
+ Hits         1388     1418      +30     
- Misses        142      143       +1     
  Partials       10       10              
Flag Coverage Δ
unittests 90.26% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@0xjcf
0xjcf merged commit ef20b6e into beta Jun 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant