Skip to content

test: cover smart-home example in root test lane - #71

Merged
0xjcf merged 1 commit into
betafrom
fas/smart-home-agent-test-lane
Jun 29, 2026
Merged

test: cover smart-home example in root test lane#71
0xjcf merged 1 commit into
betafrom
fas/smart-home-agent-test-lane

Conversation

@0xjcf

@0xjcf 0xjcf commented Jun 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • Extend the root test script so it runs the existing ignite-element package suite and the smart-home agent example tests.
  • Keeps the smart-home example outside the pnpm workspace while satisfying FAS full-lane coverage for the new example test file.

Verification

  • npm run test
  • FAS_PROCESS_PRESSURE_PREFLIGHT=0 .fas/scripts/verify.sh --full
  • fas validate-task

Summary by CodeRabbit

  • Tests
    • Expanded the main test command to run the existing package tests and also execute the smart-home example’s Vitest suite.

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f7779a8d-4958-4d3a-b7b1-86c843b6f9ca

📥 Commits

Reviewing files that changed from the base of the PR and between eabc37d and a1d45a7.

📒 Files selected for processing (1)
  • package.json

Walkthrough

The root scripts.test in package.json is extended to chain a Vitest run for examples/agents/smart-home (with explicit --root and --config paths) after the existing ignite-element test suite.

Changes

Test Script Extension

Layer / File(s) Summary
Root test script update
package.json
scripts.test now chains vitest --run --root ../../examples/agents/smart-home --config ../../examples/agents/smart-home/vite.config.ts after the existing ignite-element test command.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 A bunny hopped to add a test,
Smart-home examples put to rest,
One script to run them, chained with care,
Vitest flags floating in the air,
More coverage now — a job well done! 🏠

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding the smart-home example to the root test lane.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fas/smart-home-agent-test-lane

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (beta@eabc37d). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             beta      #71   +/-   ##
=======================================
  Coverage        ?   89.96%           
=======================================
  Files           ?       32           
  Lines           ?     1515           
  Branches        ?      433           
=======================================
  Hits            ?     1363           
  Misses          ?      142           
  Partials        ?       10           
Flag Coverage Δ
unittests 89.96% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@0xjcf

0xjcf commented Jun 29, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@0xjcf
0xjcf merged commit 4248585 into beta Jun 29, 2026
6 checks passed
@0xjcf
0xjcf deleted the fas/smart-home-agent-test-lane branch June 29, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant