Skip to content

ci: example-typecheck job + deterministic example lockfiles - #66

Merged
0xjcf merged 1 commit into
betafrom
ci/example-typecheck
Jun 23, 2026
Merged

ci: example-typecheck job + deterministic example lockfiles#66
0xjcf merged 1 commit into
betafrom
ci/example-typecheck

Conversation

@0xjcf

@0xjcf 0xjcf commented Jun 23, 2026

Copy link
Copy Markdown
Owner

What

Adds an examples-typecheck job to CI and commits a pnpm-lock.yaml for all 8 top-level examples.

Why

Examples were relocated to top-level examples/ (#65) and dropped from the library's gated typecheck (they're self-contained, non-workspace members) — so nothing in CI caught example regressions (CodeRabbit flagged this on #65). This restores coverage.

The job

Per example: root pnpm install (library tsc + ignite-* sources), then pnpm install --ignore-workspace --no-link-workspace-packages + tsc --project <example>/tsconfig.json (the example tsconfigs map ignite-element/@ignite-element/* to local package source). Loops all 8, collects every failure, fails if any breaks (no fail-fast). Runs on the existing PR-into-beta triggers; the release job stays main-push-only.

Lockfiles

Committed for all 8 examples so the per-example installs are deterministic — adds the lit-html entry declared in #65 (xstate), reconciles the stale adapter lockfiles to their package.json, and adds previously-missing lockfiles for the apps/frameworks examples. Reflects the verified 8/8-typecheck state.

Verification

  • All 8 examples typecheck locally (the exact commands the job runs).
  • verify.sh --full green (no regression to the library lanes).
  • This PR's own examples-typecheck job is the live proof in CI.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b1f2b3c0-5552-4c8a-9dd9-210d4f67334b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/example-typecheck

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (beta@1963978). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             beta      #66   +/-   ##
=======================================
  Coverage        ?   89.76%           
=======================================
  Files           ?       30           
  Lines           ?     1485           
  Branches        ?      426           
=======================================
  Hits            ?     1333           
  Misses          ?      142           
  Partials        ?       10           
Flag Coverage Δ
unittests 89.76% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…istic installs

Examples were relocated to top-level examples/ (#65) and dropped from the library's gated typecheck (they're self-contained, non-workspace), so nothing in CI caught example regressions.

- Add an examples-typecheck job to ci.yml: root pnpm install (library tsc + ignite-* sources), then per example a self-contained 'pnpm install --ignore-workspace --no-link-workspace-packages' + 'tsc --project <example>/tsconfig.json' (the example tsconfigs map ignite-element/@ignite-element/* to local package source). Loops all 8 examples, collects every failure, fails if any breaks. Runs on the existing PR-into-beta triggers; the release job stays main-push-only.
- Commit a pnpm-lock.yaml for all 8 examples so the per-example installs are deterministic: adds the lit-html entry declared in #65 (xstate), reconciles the stale adapter lockfiles to their package.json, and adds previously-missing lockfiles for the apps/frameworks examples.
- Fix the svelte example tsconfig: add the missing @ignite-element/adapters/{xstate,actor-web} path mappings the library source needs (it passed locally only via leftover node_modules; the clean CI install exposed the gap).
@0xjcf
0xjcf force-pushed the ci/example-typecheck branch from ab3a178 to 31951ad Compare June 23, 2026 04:51
@0xjcf
0xjcf merged commit 660c729 into beta Jun 23, 2026
6 checks passed
@0xjcf
0xjcf deleted the ci/example-typecheck branch June 23, 2026 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant