ci: example-typecheck job + deterministic example lockfiles - #66
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## beta #66 +/- ##
=======================================
Coverage ? 89.76%
=======================================
Files ? 30
Lines ? 1485
Branches ? 426
=======================================
Hits ? 1333
Misses ? 142
Partials ? 10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…istic installs Examples were relocated to top-level examples/ (#65) and dropped from the library's gated typecheck (they're self-contained, non-workspace), so nothing in CI caught example regressions. - Add an examples-typecheck job to ci.yml: root pnpm install (library tsc + ignite-* sources), then per example a self-contained 'pnpm install --ignore-workspace --no-link-workspace-packages' + 'tsc --project <example>/tsconfig.json' (the example tsconfigs map ignite-element/@ignite-element/* to local package source). Loops all 8 examples, collects every failure, fails if any breaks. Runs on the existing PR-into-beta triggers; the release job stays main-push-only. - Commit a pnpm-lock.yaml for all 8 examples so the per-example installs are deterministic: adds the lit-html entry declared in #65 (xstate), reconciles the stale adapter lockfiles to their package.json, and adds previously-missing lockfiles for the apps/frameworks examples. - Fix the svelte example tsconfig: add the missing @ignite-element/adapters/{xstate,actor-web} path mappings the library source needs (it passed locally only via leftover node_modules; the clean CI install exposed the gap).
ab3a178 to
31951ad
Compare
What
Adds an
examples-typecheckjob to CI and commits apnpm-lock.yamlfor all 8 top-level examples.Why
Examples were relocated to top-level
examples/(#65) and dropped from the library's gated typecheck (they're self-contained, non-workspace members) — so nothing in CI caught example regressions (CodeRabbit flagged this on #65). This restores coverage.The job
Per example: root
pnpm install(librarytsc+ ignite-* sources), thenpnpm install --ignore-workspace --no-link-workspace-packages+tsc --project <example>/tsconfig.json(the example tsconfigs mapignite-element/@ignite-element/*to local package source). Loops all 8, collects every failure, fails if any breaks (no fail-fast). Runs on the existing PR-into-beta triggers; thereleasejob stays main-push-only.Lockfiles
Committed for all 8 examples so the per-example installs are deterministic — adds the
lit-htmlentry declared in #65 (xstate), reconciles the stale adapter lockfiles to theirpackage.json, and adds previously-missing lockfiles for the apps/frameworks examples. Reflects the verified 8/8-typecheck state.Verification
verify.sh --fullgreen (no regression to the library lanes).examples-typecheckjob is the live proof in CI.