Add Windows Support to SelectableLabel Control#8
Merged
Merged
Conversation
Co-authored-by: 0xc3u <45848928+0xc3u@users.noreply.github.com>
Co-authored-by: 0xc3u <45848928+0xc3u@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add Windows Support
Add Windows Support to SelectableLabel Control
Aug 6, 2025
0xc3u
requested changes
Aug 6, 2025
0xc3u
left a comment
Owner
There was a problem hiding this comment.
Please use .net9
net9.0-android;net9.0-ios;net9.0-windows10.0.19041.0
instead of net8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive Windows support to the Indiko.Maui.Controls.SelectableLabel library, enabling the control to work seamlessly across all major MAUI platforms.
What's Added
Windows Platform Handler
RichTextBlockcontrolIsTextSelectionEnabled = trueTarget Framework Support
net8.0-windows10.0.19041.0target framework to the libraryComplete Feature Implementation
The Windows handler supports all existing SelectableLabel features:
Platform-Specific Optimizations
RichTextBlockfor optimal text selection experience on WindowsTextAlignment,TextWrapping)TextTrimmingfor ellipsis behaviorBug Fixes
Also fixed existing issues in the core
SelectableLabelclass:MaxLinesPropertyBindableProperty declaration (was incorrectly usingnameof(LineHeight))TextTransformPropertyBindableProperty declaration (was incorrectly usingnameof(TextDecorations))Developer Experience
Usage Example
The implementation follows the established patterns from other platform handlers and ensures consistent behavior across all supported platforms.
Fixes #7.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.