Durian audit fixes - #421
Open
hecmas wants to merge 1 commit into
Open
Conversation
hecmas
force-pushed
the
fix/durian-audit
branch
from
January 15, 2025 09:53
c69718f to
b96e2cc
Compare
Merged
laisolizq
force-pushed
the
fix/durian-audit
branch
from
January 27, 2025 14:50
b96e2cc to
44cf855
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes minor changes to comments in the
dblScalarMulSecp256r1_save_k10_k21andp256verify_correctness_checkstags:main/p256verify/dblScalarMulSecp256r1.zkasm: Added a comment to explain that theJMPNinstruction is left for understanding purposes, even thoughRR - 1 >= 0.main/p256verify/p256verify.zkasm: Updated the comment to clarify that an early return is performed ifPK = (x,y)is the point at infinity(0,0), which would also be caught by the elliptic curve equation check.