Big optmizations to ecAdd, ecMul and ecPairing and small refactor - #328
Draft
hecmas wants to merge 12 commits into
Draft
Big optmizations to ecAdd, ecMul and ecPairing and small refactor#328hecmas wants to merge 12 commits into
hecmas wants to merge 12 commits into
Conversation
hecmas
requested review from
ignasirv,
jesusholoo,
krlosMata and
laisolizq
as code owners
February 5, 2024 19:01
hecmas
changed the base branch from
develop-feijoa
to
feature/precompiled-optz
February 5, 2024 19:03
hecmas
changed the base branch from
feature/precompiled-optz
to
develop-feijoa
February 5, 2024 19:05
krlosMata
marked this pull request as draft
February 7, 2024 13:52
hecmas
marked this pull request as ready for review
February 22, 2024 08:39
|
krlosMata
force-pushed
the
develop-feijoa
branch
from
March 7, 2024 12:08
a302c6a to
f7290c3
Compare
krlosMata
marked this pull request as draft
March 22, 2024 15:42
hecmas
force-pushed
the
feature/bn254-optz
branch
from
May 30, 2024 15:54
cb4a5e6 to
d8011e4
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




This PR contains the following significative optimizations:
ecMul.zkasmcalls toecAdd.zkasmnow to avoid unnecessary checks.doublePointBN254.zkasmto perform doublings.ecMul.zkasmnow does not use any binary to perform the scalarkreconstruction.bitwiseReconstruction.zkasmhas been added to allow "fill in" the missing bits of a particularscalarMulBN254, we now usescalarMulFP2BN254to put emphasy on the underlying finite field.ecAdd,ecMulandecPairing.