Reject network account mutations in RPC#2252
Open
AlgofootPrint wants to merge 1 commit into
Open
Conversation
Mirko-von-Leipzig
requested changes
Jun 15, 2026
Mirko-von-Leipzig
left a comment
Collaborator
There was a problem hiding this comment.
Diffs in the other files seem unrelated to this PR.
Collaborator
There was a problem hiding this comment.
This diff seem unrelated
Contributor
Author
There was a problem hiding this comment.
My apologies, that came from an unrelated commit that was accidentally included underneath this branch.
I rebased the PR onto current next and force-pushed a cleaned version. The diff is now scoped to the RPC-side rejection for #2146 and no longer includes crates/store/src/state/mod.rs.
fe793db to
e4d2081
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #2146.
Testing
git diff --checkpasses, with line-ending warnings onlycargo test -p miden-node-rpc server::api::testscould not complete becausemiden-node-proto-buildfailed first:file 'C:\Users\damio\Desktop\PR\node\proto\proto\remote_prover.proto' is not in any include path