Skip to content

Reject network account mutations in RPC#2252

Open
AlgofootPrint wants to merge 1 commit into
0xMiden:nextfrom
AlgofootPrint:fix/reject-network-account-mutation
Open

Reject network account mutations in RPC#2252
AlgofootPrint wants to merge 1 commit into
0xMiden:nextfrom
AlgofootPrint:fix/reject-network-account-mutation

Conversation

@AlgofootPrint

Copy link
Copy Markdown
Contributor

Summary

  • reject submitted transactions when an existing non-network account delta touches the standardized network-account allowlist slot
  • apply the same RPC-side check to each transaction in submitted batches
  • add focused unit coverage for the rejection path and existing network-account allowance

Part of #2146.

Testing

  • git diff --check passes, with line-ending warnings only
  • cargo test -p miden-node-rpc server::api::tests could not complete because miden-node-proto-build failed first: file 'C:\Users\damio\Desktop\PR\node\proto\proto\remote_prover.proto' is not in any include path

@Mirko-von-Leipzig Mirko-von-Leipzig left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diffs in the other files seem unrelated to this PR.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff seem unrelated

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, that came from an unrelated commit that was accidentally included underneath this branch.

I rebased the PR onto current next and force-pushed a cleaned version. The diff is now scoped to the RPC-side rejection for #2146 and no longer includes crates/store/src/state/mod.rs.

@AlgofootPrint AlgofootPrint force-pushed the fix/reject-network-account-mutation branch from fe793db to e4d2081 Compare June 15, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants