Skip to content

Fix Japanese localization strings for clarity - #778

Merged
0xCUB3 merged 1 commit into
0xCUB3:mainfrom
so-5699:patch-1
Sep 8, 2026
Merged

Fix Japanese localization strings for clarity#778
0xCUB3 merged 1 commit into
0xCUB3:mainfrom
so-5699:patch-1

Conversation

@so-5699

@so-5699 so-5699 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Sorry. I thought "powered by Dearrow" would be easier to understand even in a Japanese environment.

Updated Japanese localization strings for clarity and consistency.
@0xCUB3
0xCUB3 merged commit bc4ea21 into 0xCUB3:main Sep 8, 2026
3 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3cf6f367b3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 761 to 765
"The following filters were automatically disabled:

%@

To re-enable these filters, disable other large filters and apply changes again." = "次のフィルターは自動的に無効になりました:

%@

再度有効にするには、他の大きなフィルターを無効にしてからもう一度変更を適用してください。";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve the full newline sequence in the localization key

When autoDisabledFilters is nonempty, ContentView.swift:1220 looks up the key containing \n\n%@\n\n. Removing these two blank lines changes this entry's key to \n\n%@\n and also removes %@ from its Japanese value, so the exact lookup misses and the auto-disabled-filters alert falls back to its English source text for Japanese users. Restore the blank separator lines around %@ in both sides of this entry.

Useful? React with 👍 / 👎.

@so-5699
so-5699 deleted the patch-1 branch September 8, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants