Fix issue-to-PR automation skipping and failing submissions - #129
Open
Trkraza wants to merge 1 commit into
Open
Conversation
Two independent faults stopped new-app issues becoming draft PRs. The job was gated on the issue title starting with "[New App]:". That prefix is only a prefill in the issue form and submitters can overwrite it, which several did (#120 became "[CiaoTool]: ..."). A renamed title skipped the job before any step ran, so no PR was opened and no failure comment posted either, since the reporting steps live inside the same job. The submission just disappeared. Gating on the `new-app` label instead is reliable, because the form applies it and the submitter cannot change it. Separately, the validate step ran `pnpm run dev:validate`, which is not a defined script; only `validate` exists. pnpm exited with ERR_PNPM_NO_SCRIPT, and because opening the PR requires the validate step to have succeeded, no PR was created even when the metadata generated cleanly (#121). CLAUDE.md documented the same three non-existent `dev:` commands, which is where the typo came from, so those are corrected too. Also adds the `edited` trigger, so a submission rejected for something the author can fix retries when they edit the issue rather than needing a maintainer to close and reopen it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent faults stopped new-app issues becoming draft PRs.
The job was gated on the issue title starting with "[New App]:". That prefix is only a prefill in the issue form and submitters can overwrite it, which several did (#120 became "[CiaoTool]: ..."). A renamed title skipped the job before any step ran, so no PR was opened and no failure comment posted either, since the reporting steps live inside the same job. The submission just disappeared. Gating on the
new-applabel instead is reliable, because the form applies it and the submitter cannot change it.Separately, the validate step ran
pnpm run dev:validate, which is not a defined script; onlyvalidateexists. pnpm exited with ERR_PNPM_NO_SCRIPT, and because opening the PR requires the validate step to have succeeded, no PR was created even when the metadata generated cleanly (#121). CLAUDE.md documented the same three non-existentdev:commands, which is where the typo came from, so those are corrected too.Also adds the
editedtrigger, so a submission rejected for something the author can fix retries when they edit the issue rather than needing a maintainer to close and reopen it.