Add support for IP65 Outdoor Thermo-Hygrometer (WoIOSensor) in overview#52
Conversation
Add support for IP65 Outdoor Thermo-Hygrometer (WoIOSensor) in overview
There was a problem hiding this comment.
Code Review
This pull request adds several new matchers to the meter device definition in deviceDefinitions.ts. A critical syntax error was identified where extra closing brackets were added, which would prevent the application from compiling. Additionally, some of the new matchers are redundant due to case normalization, and the feedback suggests removing non-standard matchers and informal comments.
| }, | ||
| ], |
There was a problem hiding this comment.
Fixed in commit db3e93c – extra brackets removed.
| "WoIOSensor", // ← dein IP65 Thermo-Hygrometer | ||
| "woiosensor", | ||
| "io sensor", | ||
| "outdoor thermo", | ||
| "ip65" |
There was a problem hiding this comment.
The matcher "WoIOSensor" is redundant because the device type is normalized to lowercase before comparison. Additionally, the comment is in German and contains personal notes. The extra matchers "io sensor", "outdoor thermo", and "ip65" are non-standard and potentially unnecessary. It is recommended to keep only the official "woiosensor" matcher.
"woiosensor",There was a problem hiding this comment.
Fixed – removed redundant matchers and German comment in commit 4d48a33. Now only "woiosensor".
Fix syntax error in meter matchers
Fix extra closing bracke.
(Clean up meter matchers - keep only official woiosensor
|
Hi @olroX-cyber |
|
I don't have the device myself so I can't test it 100%, but the code looks good! |
Hi @0suu,
I added support for the SwitchBot IP65 Thermo-Hygrometer (
WoIOSensor) so that temperature and humidity are now displayed directly in the Devices overview — exactly like the normal Meter / Meter Plus.Change made in
deviceDefinitions.ts: