Skip to content

Add support for IP65 Outdoor Thermo-Hygrometer (WoIOSensor) in overview#52

Merged
0suu merged 4 commits into
0suu:mainfrom
olroX-cyber:main
May 18, 2026
Merged

Add support for IP65 Outdoor Thermo-Hygrometer (WoIOSensor) in overview#52
0suu merged 4 commits into
0suu:mainfrom
olroX-cyber:main

Conversation

@olroX-cyber

Copy link
Copy Markdown
Contributor

Hi @0suu,

I added support for the SwitchBot IP65 Thermo-Hygrometer (WoIOSensor) so that temperature and humidity are now displayed directly in the Devices overview — exactly like the normal Meter / Meter Plus.

Change made in deviceDefinitions.ts:

{
  key: "meter",
  matchers: [
    "meter plus",
    "meter pro co2",
    "meter pro",
    "outdoor meter",
    "meter",
    "WoIOSensor",      // ← added
    "woiosensor"
  ],
  statusFields: [
    ...tempHumidityFields,
    // CO2 field stays the same
  ],
},

Add support for IP65 Outdoor Thermo-Hygrometer (WoIOSensor) in overview

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds several new matchers to the meter device definition in deviceDefinitions.ts. A critical syntax error was identified where extra closing brackets were added, which would prevent the application from compiling. Additionally, some of the new matchers are redundant due to case normalization, and the feedback suggests removing non-standard matchers and informal comments.

Comment thread src/renderer/src/deviceDefinitions.ts Outdated
Comment on lines +774 to +775
},
],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change introduces extra closing brackets (}, and ],) which will cause a syntax error and prevent the application from compiling. The meter definition is already correctly closed by the following line.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit db3e93c – extra brackets removed.

Comment thread src/renderer/src/deviceDefinitions.ts Outdated
Comment on lines +760 to +764
"WoIOSensor", // ← dein IP65 Thermo-Hygrometer
"woiosensor",
"io sensor",
"outdoor thermo",
"ip65"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The matcher "WoIOSensor" is redundant because the device type is normalized to lowercase before comparison. Additionally, the comment is in German and contains personal notes. The extra matchers "io sensor", "outdoor thermo", and "ip65" are non-standard and potentially unnecessary. It is recommended to keep only the official "woiosensor" matcher.

      "woiosensor",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed – removed redundant matchers and German comment in commit 4d48a33. Now only "woiosensor".

Fix syntax error in meter matchers
Fix extra closing bracke.
(Clean up meter matchers - keep only official woiosensor
@0suu

0suu commented May 14, 2026

Copy link
Copy Markdown
Owner

Hi @olroX-cyber
Thank you for your contribution! I'll review it in the next few days.

@0suu

0suu commented May 18, 2026

Copy link
Copy Markdown
Owner

@olroX-cyber

I don't have the device myself so I can't test it 100%, but the code looks good!
I'll go ahead and merge it. Thanks!

@0suu 0suu merged commit 54fbb31 into 0suu:main May 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants