リリースワークフローを変更#50
Merged
Merged
Conversation
Deploying switchbotcontroller with
|
| Latest commit: |
c257411
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://609180d6.switchbotcontroller.pages.dev |
| Branch Preview URL: | https://fix-release-workflow.switchbotcontroller.pages.dev |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the package.json configuration to disable the 'v' prefix for release tags by setting vPrefixedTagName to false. Feedback points out that this change may break existing CI/CD workflows, such as GitHub Actions, if they are configured to trigger specifically on tags starting with 'v'.
| "owner": "0suu", | ||
| "repo": "SwitchBotController" | ||
| "repo": "SwitchBotController", | ||
| "vPrefixedTagName": false |
There was a problem hiding this comment.
タグ名から v プレフィックスを削除（vPrefixedTagName: false）すると、GitHub Actions などのワークフローでタグのプッシュをトリガーにしている場合（例: on: push: tags: - 'v*'）、トリガー条件に一致しなくなり自動化が停止する可能性があります。リリース自動化を維持するためには、ワークフロー側のトリガー条件も更新する必要があります。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.