Skip to content

エアコンカード日本語対応#27

Merged
0suu merged 1 commit into
mainfrom
suu/FixAirConditionerJapaneseText
Dec 29, 2025
Merged

エアコンカード日本語対応#27
0suu merged 1 commit into
mainfrom
suu/FixAirConditionerJapaneseText

Conversation

@0suu

@0suu 0suu commented Dec 29, 2025

Copy link
Copy Markdown
Owner

No description provided.

@0suu 0suu merged commit 3f8f283 into main Dec 29, 2025
2 checks passed
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @0suu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces Japanese language support for the air conditioner control card. It achieves this by internationalizing the relevant UI text elements within the DeviceControls component and providing the corresponding Japanese translations in the application's internationalization dictionary, making the interface more accessible to Japanese-speaking users.

Highlights

  • Internationalization of AC Card UI: Various UI labels within the DeviceControls.tsx component, including temperature, mode, fan speed, and power settings, have been wrapped with the t() translation function to enable multi-language support.
  • Japanese Translation Support: New Japanese translation entries have been added to i18n.ts for all the internationalized terms related to the air conditioner controls, such as 'Mode', 'Fan speed', 'Power', and various AC modes.
  • Expanded English Translation Keys: Corresponding English keys for the newly translatable strings have been added to the i18n.ts file, ensuring consistency and proper fallback for the base language.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

このプルリクエストでは、エアコン操作カードのUIテキストを国際化し、日本語訳を追加しています。変更は適切に行われていますが、i18n.tsファイル内の翻訳キーの順序を他のキーと合わせることで、保守性が向上します。全体として、多言語対応に向けた良い変更です。

Comment thread src/renderer/src/i18n.ts
Comment on lines +98 to +108
Mode: "Mode",
"Fan speed": "Fan speed",
Power: "Power",
"Temperature (°C)": "Temperature (°C)",
Low: "Low",
Medium: "Medium",
High: "High",
Cool: "Cool",
Dry: "Dry",
Fan: "Fan",
Heat: "Heat",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

翻訳キーの追加ありがとうございます。コードの可読性と保守性を高めるため、関連するキーをグループ化することをお勧めします。例えば、Cool, Dry, Fan, HeatHigh の後ではなく、Auto の近くに配置すると、モード関連のキーとしてまとまりが良くなります。

Suggested change
Mode: "Mode",
"Fan speed": "Fan speed",
Power: "Power",
"Temperature (°C)": "Temperature (°C)",
Low: "Low",
Medium: "Medium",
High: "High",
Cool: "Cool",
Dry: "Dry",
Fan: "Fan",
Heat: "Heat",
Auto: "Auto",
Cool: "Cool",
Dry: "Dry",
Fan: "Fan",
Heat: "Heat",
Mode: "Mode",
"Fan speed": "Fan speed",
Power: "Power",
"Temperature (°C)": "Temperature (°C)",
Low: "Low",
Medium: "Medium",
High: "High",

Comment thread src/renderer/src/i18n.ts
Comment on lines +244 to +254
Mode: "モード",
"Fan speed": "風量",
Power: "電源",
"Temperature (°C)": "温度 (°C)",
Low: "弱",
Medium: "中",
High: "強",
Cool: "冷房",
Dry: "除湿",
Fan: "送風",
Heat: "暖房",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

日本語の翻訳キー追加、ありがとうございます。英語版と同様に、関連するキーをグループ化すると、将来のメンテナンスが容易になります。Cool, Dry, Fan, HeatAuto の後に移動させることを検討してください。

Suggested change
Mode: "モード",
"Fan speed": "風量",
Power: "電源",
"Temperature (°C)": "温度 (°C)",
Low: "弱",
Medium: "中",
High: "強",
Cool: "冷房",
Dry: "除湿",
Fan: "送風",
Heat: "暖房",
Auto: "自動",
Cool: "冷房",
Dry: "除湿",
Fan: "送風",
Heat: "暖房",
Mode: "モード",
"Fan speed": "風量",
Power: "電源",
"Temperature (°C)": "温度 (°C)",
Low: "弱",
Medium: "中",
High: "強",

@0suu 0suu deleted the suu/FixAirConditionerJapaneseText branch December 29, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant