Skip to content

気化式加湿器のチャイルドロックボタンは詳細画面にだけ表示#25

Merged
0suu merged 1 commit into
mainfrom
suu/Fix-device-card-layout
Dec 29, 2025
Merged

気化式加湿器のチャイルドロックボタンは詳細画面にだけ表示#25
0suu merged 1 commit into
mainfrom
suu/Fix-device-card-layout

Conversation

@0suu

@0suu 0suu commented Dec 29, 2025

Copy link
Copy Markdown
Owner

No description provided.

@0suu
0suu merged commit f6e63a7 into main Dec 29, 2025
1 of 2 checks passed
@0suu
0suu deleted the suu/Fix-device-card-layout branch December 29, 2025 14:48
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @0suu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

このプルリクエストは、気化式加湿器のチャイルドロックボタンの表示ロジックを改善します。以前は特定の条件で表示されていましたが、今回の変更により、チャイルドロックボタンはデバイスの詳細画面でのみ表示されるようになります。これにより、ユーザーインターフェースの明確性が向上し、関連性のない画面でのボタンの表示が避けられます。

Highlights

  • DeviceControlsコンポーネントへの新しいプロパティの追加: DeviceControlsPropsインターフェースにshowChildLockControls?: boolean;プロパティが追加され、チャイルドロックコントロールの表示を制御できるようになりました。
  • チャイルドロックコントロールのデフォルト表示設定: DeviceControlsコンポーネント内で、showChildLockControlsプロパティのデフォルト値がfalseに設定されました。これにより、明示的に有効にしない限り、チャイルドロックコントロールは表示されません。
  • チャイルドロックボタンの表示ロジックの変更: 気化式加湿器のチャイルドロックボタンのレンダリング条件が変更され、isEvaporativeHumidifiertrueであることに加えて、showChildLockControlsプロパティもtrueである場合にのみ表示されるようになりました。
  • DeviceDetailScreenでのチャイルドロックコントロールの有効化: DeviceDetailScreenコンポーネントがDeviceControlsを使用する際に、showChildLockControlsプロパティが明示的にtrueに設定されました。これにより、詳細画面でのみチャイルドロックボタンが表示されます。

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@0suu
0suu restored the suu/Fix-device-card-layout branch December 29, 2025 14:49

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces a new boolean prop, showChildLockControls, to the DeviceControls component, which defaults to false. This prop is used to conditionally render child lock controls, making them visible only for evaporative humidifiers when showChildLockControls is true. The DeviceDetailScreen component has been updated to pass this new showChildLockControls prop to DeviceControls, effectively enabling these controls within the device detail view. There are no review comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant