Remove gitoxide: standardize local read-only ops on the git subprocess backend#138
Merged
Conversation
…s backend Co-Authored-By: Staging-Devin AI <166158716+staging-devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
0lut
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
gix(gitoxide) dependency and the dual-backend layer it existed for. The five local read-only operations (rev_parse,is_ancestor,for_each_ref,for_each_ref_commits,cat_file_batch_types) were previously dispatched through aLocalGitBackendtrait with two implementations (in-processGixBackend— the default — and subprocessGitBackend), selected viause_gitoxideconfig /GIT_CACHE_USE_GITOXIDE. That meant maintaining two parity-tested implementations of every op while all mutating and network paths already went through thegitbinary.crates/git-cache-git/src/backend.rsandsrc/gix_backend.rs; the formerGitBackendbodies are inlined into the correspondingGitmethods, so behavior matches the previoususe_gitoxide = falsepath exactly. Input validation (reject_revision_arg,reject_ref_arg) is unchanged and still happens before argv composition.AppConfig.use_gitoxide,default_use_gitoxide, andGIT_CACHE_USE_GITOXIDEenv parsing (unknown TOML keys and env vars were already ignored, so existing deployment configs won't break). README row dropped.git_wrapper.rsand collapsed the_gix_backend/_git_backendduplicate regression tests ingit_client_advanced.rsinto one;TestServer::start_with_file_url_upstreamloses its backend parameter.gixfrom the workspace andasync-traitfromgit-cache-git(only the deleted trait used it); Cargo.lock sheds ~60 transitivegix-*crates.Release notes
No user facing change (the previously default in-process gitoxide backend is removed; all local read-only Git operations now run through the
gitbinary, matching the existingGIT_CACHE_USE_GITOXIDE=falsebehavior).Link to Devin session: https://staging.itsdev.in/sessions/f90f17d194054a468473b35247f3177e
Requested by: @0lut
Devin Review