Skip to content

Remove git remote enable switch#115

Merged
0lut merged 1 commit into
mainfrom
codex/remove-git-remote-enabled
Jun 12, 2026
Merged

Remove git remote enable switch#115
0lut merged 1 commit into
mainfrom
codex/remove-git-remote-enabled

Conversation

@0lut

@0lut 0lut commented Jun 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • register the /git/{*repo_path} route unconditionally
  • remove GitRemoteConfig.enabled and the GIT_CACHE_GIT_REMOTE_ENABLED env/config knob
  • clean up Helm values, examples, integration configs, README docs, and agent runbooks that referenced the old switch

Verification

  • cargo fmt --check
  • cargo test -p git-cache-core config::tests:: -- --nocapture
  • cargo test --test git_remote_integration -- --nocapture
  • cargo check --workspace
  • helm template git-cache deploy/helm/gitmirrorcache --set config.objectStore.s3.bucket=test-bucket
  • git diff --check

Open in Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

- `allowed_upstream_hosts = ["github.com"]`
- `[disk] min_free_bytes = 0` for small local test fixtures
- `[git_remote] enabled = true` if testing HTTP git routes
- HTTP git routes are always served; add `[git_remote]` only for read-through or proxy tuning

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • HTTP git routes are always served; add [git_remote] only for read-through or proxy tuning

what does it mean? we do not need to explain every feature

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed that extra note instead of explaining the always-on behavior, and also trimmed the sample git_remote block since the defaults cover it.

@0lut
0lut force-pushed the codex/remove-git-remote-enabled branch from 083eded to 2425442 Compare June 12, 2026 07:30
@0lut
0lut merged commit e6b0ad2 into main Jun 12, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant