Skip to content

Feat/core reliability - #6

Merged
0ldev merged 5 commits into
0ldev:developfrom
thomazbandeira:feat/core-reliability
Oct 29, 2026
Merged

0ldev merged 5 commits into
0ldev:developfrom
thomazbandeira:feat/core-reliability

Conversation

@thomazbandeira

Copy link
Copy Markdown
Contributor

What does this PR do?

Type of change

  • Bug fix
  • New feature / capture primitive
  • New example
  • Documentation / translation
  • CI / workflow change
  • Performance improvement
  • Other (describe below)

Checklist

  • I've read CONTRIBUTING.md
  • My branch is based off develop, not main
  • All existing examples still compile (pio run in each example directory)
  • If I added a new example, I added it to the CI matrix in build-examples.yml
  • If I added a new example, I added it to the examples table in README.md
  • If I changed the public API, I updated the relevant docstrings/documentation

CI / workflow changes (fill in if applicable)

  • All new/modified uses: actions are pinned to an immutable commit SHA (not a floating tag like @v4)
  • Artifact upload steps include if: github.event_name == 'push'
  • No new pull_request_target: triggers

Testing

Related issues

@0ldev 0ldev left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a real improvement over main's shutdown behavior, but it introduces two concurrency bugs of its own that need fixing before merge (one is a genuine use-after-free race). Third comment is a minor efficiency nit, not blocking.

Comment thread src/Politician.cpp Resolved
Comment thread src/Politician.cpp Resolved
Comment thread src/Politician.cpp Resolved
@0ldev
0ldev changed the base branch from main to develop October 28, 2026 16:54
@0ldev
0ldev force-pushed the feat/core-reliability branch from dc0af65 to 8b75bf3 Compare October 28, 2026 19:38

@0ldev 0ldev left a comment •

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: clean and verified.

@0ldev
0ldev merged commit 479edd2 into 0ldev:develop Oct 29, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants