Repository navigation
example: add ESP-NOW capture example - #5
Merged
Merged
Conversation
0ldev
requested changes
Sep 25, 2026
0ldev
left a comment
0ldev
left a comment
Owner
There was a problem hiding this comment.
Solid addition, but a few things should be fixed before merge:
- Include esp_timer.h in politician_compat.h under ARDUINO - Restore accurate WPS M1 callback docstring in Politician.h - Clarify buffer lifetime and memcpy recommendation in EspNowRecord - Update EspNowCapture platformio.ini to use symlink lib_deps - Add EspNowCapture to build-examples CI matrix and pin action SHAs - Document EspNowCapture in README examples table
0ldev
approved these changes
Oct 28, 2026
0ldev
left a comment
0ldev
left a comment
Owner
There was a problem hiding this comment.
All requested feedback addressed and verified. Includes are clean, platformio config standardized, and all 17 example CI builds plus CodeQL pass without warnings. Merging into develop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.