Skip to content

Fix Builds (see #22 for details) [ DO NOT MERGE ] - #23

Closed
drojf wants to merge 28 commits into
modfrom
fix-builds
Closed

Fix Builds (see #22 for details) [ DO NOT MERGE ]#23
drojf wants to merge 28 commits into
modfrom
fix-builds

Conversation

@drojf

@drojf drojf commented Jun 25, 2025

Copy link
Copy Markdown

Previous Discussion

github.com//pull/22

Problems with Builds

We had some issues with the mac, windows, and any steam builds, after not doing any builds for a long time (presumably because the github runners etc. have updated):

  • steam: Our old server is gone, and the build used files from the our server for the steam build, so this doesn't work
  • mac: fixed by applying this patch github.com/Add confirmation to the SHIFT-Q shortcut before closing the game #22#issuecomment-2993319930
  • windows: kind of fixed by a combination of actual fixes and in other cases, forcing the build to continue despite errors (what were previously warnings are now errors under upgraded gcc).
    • Note that the fixes for Windows were aided by ChatGPT as I didn't have enough knowledge about this stuff, so they should be vetted before committing.

TODO

  • Simplify these commits, there should only be like 5 changes
  • Check/vet any changes which are unusual or just force the build to succeed
  • Fix steam builds? or if too difficult just give up.

Updated the deprecated runners
Hopefully we can get something usable now?
…chatGPT

(note: below written by me, not chatGP)
- The config log shows error "configure:626:1: error: return type defaults to 'int' [-Wimplicit-int]
main(){return(0);}"
- Basically, the code to test jpeg-6b in .configure omits the return type for main, which isn't allowed anymore, see "Implicit int types " https://gcc.gnu.org/gcc-14/porting_to.html
 - NOTE: remove if using external SDL2?
…if this will break the final .exe output)"

This reverts commit bf788e8.
@drojf

drojf commented Jun 27, 2025

Copy link
Copy Markdown
Author

EDIT: delete this branch after applying tellowkrinkle's fixes, see #22 (comment)

@drojf drojf changed the title Fix Builds (see #22 for details) Fix Builds (see #22 for details) [ DO NOT MERGE ] Jun 27, 2025
@drojf drojf closed this Jun 29, 2025
@drojf

drojf commented Jun 29, 2025

Copy link
Copy Markdown
Author

Closed in favor of #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants