Add development handoff, make data refresh idempotent - #2
Merged
Conversation
The refresh script stamped a fresh `generated` timestamp on every run, so the snapshots differed even when upstream data was identical. The workflow's "commit if anything changed" guard therefore fired every week regardless, which would have added 52 empty commits a year. The timestamp is now carried over when the data itself is unchanged, leaving the files byte-identical. Adds HANDOFF.md covering module boundaries, the invariants worth preserving, the PoGoAPI form-ordering and form-qualified-name traps, and the backlog. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
✅ Deploy Preview for sundance-dgen ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1, from what the first real workflow run exposed.
The refresh workflow committed noise. Its manual run produced an identical snapshot (1420 entries, same data) but a new
generatedtimestamp — so the files differed, and the workflow's "commit if anything changed" guard fired anyway. Left alone that's ~52 empty commits a year. The timestamp is now preserved when the underlying data hasn't moved, so a quiet week leaves the files byte-identical and there is genuinely nothing to commit.Adds
HANDOFF.mdfor future development: module boundaries and what each file must not do, the invariants worth preserving (one description renderer,specialFieldsdrives output, noawaitbefore listener registration), the two PoGoAPI traps that cost real debugging time (base forms aren't listed first; form-qualified names have no entry of their own), testing conventions, deployment notes, and the backlog.🤖 Generated with Claude Code