Convert more sensors to diagnostic entities

[AlCalzone]

While testing the Zooz Titan Valve Actuator, I found a couple more sensors that shouldn't be listed under sensors:

Diagnostics:
zwave_js-01JYE8Z720FMMRK47FNWVE9JKX-Titan Water Valve Actuator-5cda37af831a775e743c36d24640eaee.json

[MartinHjelmare]

My smoke alarm sensor that has a heat sensor uses the overheat detected value for the heat alarm. We don't know that this value is always a diagnostic sensor.

[AlCalzone]

We could make this dependent on the device class of the device. This device is a "Binary Switch" (at least in Z-Wave terms), where I would consider a heat alarm to be diagnostic.

[MartinHjelmare]

My smoke alarm has node generic device class "Notification Sensor".

Should we consider all overheat detected values diagnostic that don't belong to a node with device class "Notification Sensor" or should we only consider overheat detected values diagnostic if they belong to a node with device class "Binary Switch"? Or something else?

[MartinHjelmare]

HeatIt Z-Smoke Battery device diagnostics:

zwave_js-ee5be67d9a9fb1d54d38c9976ff93319-Z-Smoke_Battery-e3b93e4832ab4d020ce7fb78c54f43e4.json

[AlCalzone]

Going through the list of device classes, I've identified a few where over/underheat may be considered primary functionality:

• Thermostat 0x08 (temperature outside of the wanted range)
• Appliance 0x06, specifically Kitchen Applicance (Oven, Fridge, Stove)
• Notification sensors 0x07
• Multilevel sensors 0x21 (I know Zooz have a temperature sensor that sends these notifications when the temperature is outside of a configured range)
• Alarm sensors 0xa1 - mostly for smoke/fire alarms

[raman325]

food for thought: is there value in allowing users to override entity categories? out of scope of this project, but it addresses the issue if it's implemented

[MartinHjelmare]

It's only protocol integrations that have a hard time to classify entity categories to some extent. Most integrations know exactly what each entity is. I'm skeptical about adding user customization then.