Skip to content

bug: timeleft formula mismatch #2

Description

@zuoxingdong

Training:

(1.0 - (pl.col("tick") / pl.col("max_tick"))).alias("timeleft")

max_tick = maximum tick value (e.g., 143 for 0-indexed 144 ticks)
At tick 143: timeleft = 1 - 143/143 = 0.0

Evaluation

time_left = float(total_ticks - timeStepIndex) / total_ticks

total_ticks = count of timesteps (144)
At tick 143: timeleft = (144-143)/144 = 0.00694

Solution:

# BEFORE:
time_left = float(total_ticks - timeStepIndex) / total_ticks

# AFTER:
time_left = float(total_ticks - 1 - timeStepIndex) / (total_ticks - 1)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions