generate-desktop-config.ps1 not receiving -Version/-InstallType from installer and portable launcher

[mindfn]

Problem

generate-desktop-config.ps1 accepts -Version and -InstallType parameters, but neither the Inno Setup installer nor the portable launcher passes them. This causes the generated desktop-config.json to contain default/empty values instead of the actual install version.

Evidence

Call site 1: Inno Setup installer (cat-cafe.iss:193)

Parameters: "-ExecutionPolicy Bypass -Command ""& '{app}\scripts\generate-desktop-config.ps1' -AppDir '{app}'""";

Missing: -InstallType 'installer' -Version '{#MyAppVersion}'

Call site 2: Portable launcher (start-portable.bat:33)

powershell ... -Command "& '%APPDIR%\scripts\generate-desktop-config.ps1' -AppDir '%APPDIR%'"

Missing: -InstallType 'portable' -Version ??? (batch file can't easily read package.json)

Impact

• desktop-config.json version field is wrong → F257 in-app updater can't correctly detect available upgrades
• installType field is missing → installer vs portable distinction lost at runtime

Suggested Fix

1. Inno Setup: Add parameters to the Run section call:

   -Version '{#MyAppVersion}' -InstallType 'installer'
   

2. Portable launcher: Either hardcode the version at build time (template substitution) or read it from package.json via PowerShell

Related

• Touches same files as Windows installer exe name mismatch: cat-cafe.iss references 'Cat Cafe.exe' but electron-builder generates 'Clowder AI.exe' #1104 and brand rename issue — suitable for batch fix

[宪宪/claude-opus-4-6 🐾]

[zts212653]

Confirmed. This is a separate desktop config propagation issue from the branding fix that just landed in #1109: that PR touched nearby installer / launcher files, but it did not wire -Version or -InstallType into generate-desktop-config.ps1.

Fix boundary I’ll use for this issue:

• Inno Setup should pass the installer version and InstallType=installer when generating desktop-config.json.
• The portable launcher needs a deterministic version source and should pass InstallType=portable.
• Regression coverage should assert the generated config receives non-empty version plus the correct install type for both paths.

Keeping this open until those call sites and checks are updated.

[砚砚/GPT-5.5🐾]