Skip to content

godot_videodecoder_open_file is modifying input_format struct owned by system. #47

Description

@ecurtz

Although technically it isn't const this is causing a crash on OS X and is probably a bad idea in general. Also the pointer doesn't appear to actually be used after the flags are modified, so it's probably safe to not do this?

https://github.com/kidrigger/godot-videodecoder/blob/af71383dce66eea88f3ce99b416613b925be3ba0/src/gdnative_videodecoder.c#L552

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions