improve combo_box

Author: xianjimli

docs/changes.md

@@ -1,5 +1,8 @@
 # 最新动态
 
+2026/9/8
+  * 修复combo_box设置options属性会导致mvvm把错误的值设置到模型的问题(感谢福明提供补丁)
+
 2026/9/7
   * 修正combo_box在没有options时获取value返回值不正确的问题(感谢福明提供补丁)
 

src/widgets/combo_box.c

@@ -90,6 +90,10 @@ static ret_t combo_box_on_destroy(widget_t* widget) {
     idle_remove(combo_box->init_popup_button_idle_id);
   }
 
+  if (combo_box->index_to_value_idle_id != TK_INVALID_ID) {
+    idle_remove(combo_box->index_to_value_idle_id);
+  }
+
   str_reset(&(combo_box->text));
   combo_box_reset_options(widget);
   TKMEM_FREE(combo_box->open_window);
@@ -311,14 +315,38 @@ ret_t combo_box_parse_options(widget_t* widget, const char* str) {
   return RET_OK;
 }
 
+static ret_t combo_box_on_idle_sync_index_to_value(const idle_info_t* idle) {
+  widget_t* widget = NULL;
+  combo_box_t* combo_box = NULL;
+  return_value_if_fail(idle != NULL, RET_BAD_PARAMS);
+
+  widget = WIDGET(idle->ctx);
+  combo_box = COMBO_BOX(widget);
+  ENSURE(combo_box);
+
+  combo_box_sync_index_to_value(widget, combo_box->selected_index, FALSE);
+  combo_box->index_to_value_idle_id = TK_INVALID_ID;
+
+  return RET_OK;
+}
+
+static ret_t combo_box_idle_sync_index_to_value(widget_t* widget) {
+  combo_box_t* combo_box = COMBO_BOX(widget);
+  ENSURE(combo_box);
+  if (!combo_box->index_to_value_idle_id) {
+    combo_box->index_to_value_idle_id = idle_add(combo_box_on_idle_sync_index_to_value, widget);
+  }
+  return RET_OK;
+}
+
 ret_t combo_box_set_options(widget_t* widget, const char* options) {
   ret_t ret = RET_FAIL;
   combo_box_t* combo_box = COMBO_BOX(widget);
   return_value_if_fail(combo_box != NULL, RET_BAD_PARAMS);
 
   ret = combo_box_parse_options(widget, options);
   if (!widget->loading) {
-    ret = combo_box_sync_index_to_value(widget, combo_box->selected_index, FALSE);
+    combo_box_idle_sync_index_to_value(widget);
   }
 
   return ret;

src/widgets/combo_box.h

@@ -232,6 +232,7 @@ typedef struct _combo_box_t {
   bool_t is_button_click;
   event_func_t on_item_click;
   void* on_item_click_ctx;
+  uint32_t index_to_value_idle_id;
   uint32_t init_popup_button_idle_id;
 } combo_box_t;
 

tests/combo_box_test.cc

@@ -447,10 +447,14 @@ TEST(ComboBox, set_options) {
   widget_t* w = combo_box_create(NULL, 10, 20, 30, 40);
 
   combo_box_set_options(w, "1:red;2:green;3:blue");
+  idle_dispatch();
+
   widget_get_text_utf8(w, text, sizeof(text) - 1);
   ASSERT_STREQ(text, "red");
 
   combo_box_set_options(w, "aaa;bbb;ccc");
+  idle_dispatch();
+
   widget_get_text_utf8(w, text, sizeof(text) - 1);
   ASSERT_STREQ(text, "aaa");