zkg fails with the same package mentioned in manifests using different URL protocols

[ckreibich]

This is via @stevesmoot and I don't have full details, but zkg apparently trips over the same package referenced via URLs with different protocols. In this case:

• A bundle has git@gitlab.com/path/to/package = main in the manifest
• A package (installed or elsewhere in the bundle) has as dependency https://gitlab.com/path/to/package *

Looks like zkg treats them as unrelated and fails. I'm a bit confused by this because at least in the file system the protocol isn't visible, so this could just be confusion about credentials at bundling vs unbundling time, zkg actually treating it as single package with the "wrong" protocol, etc.

@stevesmoot if you have more error output, that'd be helpful.

[stevesmoot]

https://github.com/stevesmoot/zeektest1/tree/main

try and get zkg to fail on including a package twice via 2 different names

zkg bundle --manifest st.manifest -- fail.bundle
The following packages will be BUNDLED into fail.bundle:
git@github.com:stevesmoot/localcountry.git (main)
https://github.com/stevesmoot/zeektest1.git (main)
https://github.com/stevesmoot/localcountry.git (main) (dependency)

Proceed? [Y/n] y
error: failed to create bundle: failed to clone https://github.com/stevesmoot/localcountry.git: Cmd('git') failed due to: exit code(128)
cmdline: git clone --recursive --depth=1 https://github.com/stevesmoot/localcountry.git /Users/smoot/.zkg/scratch/bundle/localcountry.git --no-single-branch
stderr: 'fatal: destination path '/Users/smoot/.zkg/scratch/bundle/localcountry.git' already exists and is not an empty directory.'

if you use the https url (from zkg.meta) in manifest in place of the ssh one:
zkg bundle --manifest st.manifest -- fail.bundle
The following packages will be BUNDLED into fail.bundle:
https://github.com/stevesmoot/localcountry.git (main)
https://github.com/stevesmoot/zeektest1.git (main)

Proceed? [Y/n] y
Bundle successfully written: fail.bundle