Follow-up to review feedback on #210 (ci: skip caching the unused local build cache on pushing runs), left unaddressed at merge time.
chatgpt-codex-connector[bot] (P2) noted that .github/workflows/ci.yml gates exclude-local-build-cache purely on github.ref == 'refs/heads/main', not on whether BuildFetch actually obtained a push token. settings.gradle.kts already handles this correctly (local.isEnabled = !remotePushEnabled), but ci.yml never got the matching fix.
Still present on main today — ci.yml:33,61,88:
exclude-local-build-cache: ${{ github.ref == 'refs/heads/main' }}
So a main run with an unprovisioned/blank BuildFetch token disables the local Gradle cache in setup-gradle even though the remote push isn't actually happening — losing caching for that run with no compensating benefit.
No reply or follow-up commit addressed this comment before #210 merged.
Follow-up to review feedback on #210 (
ci: skip caching the unused local build cache on pushing runs), left unaddressed at merge time.chatgpt-codex-connector[bot](P2) noted that.github/workflows/ci.ymlgatesexclude-local-build-cachepurely ongithub.ref == 'refs/heads/main', not on whether BuildFetch actually obtained a push token.settings.gradle.ktsalready handles this correctly (local.isEnabled = !remotePushEnabled), butci.ymlnever got the matching fix.Still present on
maintoday —ci.yml:33,61,88:So a
mainrun with an unprovisioned/blank BuildFetch token disables the local Gradle cache insetup-gradleeven though the remote push isn't actually happening — losing caching for that run with no compensating benefit.No reply or follow-up commit addressed this comment before #210 merged.