Skip to content

Commit ae473f4

Browse files
pepijndevosPepijn de Vosclaude
authored
Fix Docker workflow failing on PRs and switch to fastcrc (YosysHQ#469)
Skip Docker Hub login on pull_request events where the DOCKERHUB_TOKEN secret is not available. Replace crc/crcmod with fastcrc in Dockerfile. Co-authored-by: Pepijn de Vos <pepijndevos@Pepijns-MacBook-Pro.local> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 6877b8d commit ae473f4

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

.github/workflows/docker-build.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ jobs:
3838
echo "Using Gowin IDE version: $VERSION"
3939
4040
- name: Log in to Docker Hub
41+
if: github.event_name == 'push'
4142
uses: docker/login-action@v3
4243
with:
4344
username: pepijndevos

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ RUN apt-get update && \
1414
apt-get install -y xxd && \
1515
echo "B016: EB" | xxd -r -g 0 - ${GOWINHOME}/IDE/bin/gw_sh
1616

17-
RUN pip install --no-cache-dir crc numpy crcmod msgspec
17+
RUN pip install --no-cache-dir numpy fastcrc msgspec
1818

1919
WORKDIR /usr/src/apicula
2020

0 commit comments

Comments
 (0)