Deprecation in HTMLPurifier: Calling trigger_error() with error_level E_USER_ERROR

[piddubnij]

Description

php 8.4:

Calling trigger_error() with error_level being equal to E_USER_ERROR is now deprecated.
https://www.php.net/manual/en/function.trigger-error.php

framework/gii/components/Pear/Text/Diff.php

259, 262, 267, 270, 276, 347

Same here but possible dead vendor code:

framework/vendors/htmlpurifier/HTMLPurifier.standalone.php

825, 2000, 2012, 2131, 2657, 2803, 3053, 3105, 3124, 3142, 3572, 3858, 4236, 4250, 4255, 4300, 4394, 5742, 5754, 6441, 7447, 7882, 13223, 17653, 17701, 22150

Package version

No response

PHP version

No response

[marcovtwout]

The issues in Pear/Text are still there upstream, but the repo is archived. We can patch these locally similar to earlier PHP compatibility fixes: https://github.com/yiisoft/yii/commits/master/framework/gii/components/Pear

The issues in HTMLPurifier can be reported here: https://github.com/ezyang/htmlpurifier. Calls to E_USER_ERROR are still present in its current source code. After they tag a new release we can upgrade it here.

[samdark]

ezyang/htmlpurifier#478

[marcovtwout]

Status: not yet fixed upstream

[hiSandog]

The split between locally patchable Pear/Text code and upstream HTMLPurifier seems important here. For the archived Pear/Text copy, a Yii-local compatibility patch plus a small PHP 8.4 CI check would avoid waiting on an upstream that will not move. For HTMLPurifier, tracking the upstream issue separately makes sense, but it may still be useful to add a deprecation baseline/test so Yii can tell whether a future vendor update actually removes all E_USER_ERROR calls.