Skip to content

Commit ed2dbff

Browse files
committed
fix(deps,lint): patch the reachable pgx vulnerability and satisfy errcheck
govulncheck reported GO-2026-5004 in github.com/jackc/pgx/v5, reachable through grove's pgdriver and fixed upstream in v5.9.2. Bumped to v5.10.0. This is a real vulnerability with a published fix, not a false positive; the shared CI's govulncheck is what surfaced it. Also completes the previous commit's error-handling change. Replacing //nolint:errcheck with a gosec annotation silenced gosec but left errcheck reporting, because the two read different directives. These repos additionally run errcheck with check-blank, so `_ =` alone is not sufficient either — the discard and the directive are both required, matching the convention already used elsewhere in the tree. One further finding came only from golangci-lint's gosec, whose rule set differs from the standalone binary: G705 "XSS" on a CLI writing an unknown subcommand to stderr through %q. Annotated — there is no HTML sink there.
1 parent aef80d2 commit ed2dbff

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ require (
7070
github.com/hashicorp/serf v0.10.4 // indirect
7171
github.com/jackc/pgpassfile v1.0.0 // indirect
7272
github.com/jackc/pgservicefile v0.0.0-20240606120523-5a60cdf6a761 // indirect
73-
github.com/jackc/pgx/v5 v5.8.0 // indirect
73+
github.com/jackc/pgx/v5 v5.10.0 // indirect
7474
github.com/jackc/puddle/v2 v2.2.2 // indirect
7575
github.com/json-iterator/go v1.1.12 // indirect
7676
github.com/klauspost/compress v1.19.1 // indirect

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,8 +202,8 @@ github.com/jackc/pgpassfile v1.0.0 h1:/6Hmqy13Ss2zCq62VdNG8tM1wchn8zjSGOBJ6icpsI
202202
github.com/jackc/pgpassfile v1.0.0/go.mod h1:CEx0iS5ambNFdcRtxPj5JhEz+xB6uRky5eyVu/W2HEg=
203203
github.com/jackc/pgservicefile v0.0.0-20240606120523-5a60cdf6a761 h1:iCEnooe7UlwOQYpKFhBabPMi4aNAfoODPEFNiAnClxo=
204204
github.com/jackc/pgservicefile v0.0.0-20240606120523-5a60cdf6a761/go.mod h1:5TJZWKEWniPve33vlWYSoGYefn3gLQRzjfDlhSJ9ZKM=
205-
github.com/jackc/pgx/v5 v5.8.0 h1:TYPDoleBBme0xGSAX3/+NujXXtpZn9HBONkQC7IEZSo=
206-
github.com/jackc/pgx/v5 v5.8.0/go.mod h1:QVeDInX2m9VyzvNeiCJVjCkNFqzsNb43204HshNSZKw=
205+
github.com/jackc/pgx/v5 v5.10.0 h1:VhSvgU2jSli8o3AqIEOTJr7rZwAEUVo4E4XhR94Zfr0=
206+
github.com/jackc/pgx/v5 v5.10.0/go.mod h1:mal1tBGAFfLHvZzaYh77YS/eC6IX9OWbRV1QIIM0Jn4=
207207
github.com/jackc/puddle/v2 v2.2.2 h1:PR8nw+E/1w0GLuRFSmiioY6UooMp6KJv0/61nB7icHo=
208208
github.com/jackc/puddle/v2 v2.2.2/go.mod h1:vriiEXHvEE654aYKXXjOvZM39qJ0q+azkZFrfEOc3H4=
209209
github.com/json-iterator/go v1.1.6/go.mod h1:+SdeFBvtyEkXs7REEP0seUULqWtbJapLOCVDaaPEHmU=

0 commit comments

Comments
 (0)