Commit ed2dbff
committed
fix(deps,lint): patch the reachable pgx vulnerability and satisfy errcheck
govulncheck reported GO-2026-5004 in github.com/jackc/pgx/v5, reachable
through grove's pgdriver and fixed upstream in v5.9.2. Bumped to v5.10.0.
This is a real vulnerability with a published fix, not a false positive; the
shared CI's govulncheck is what surfaced it.
Also completes the previous commit's error-handling change. Replacing
//nolint:errcheck with a gosec annotation silenced gosec but left errcheck
reporting, because the two read different directives. These repos additionally
run errcheck with check-blank, so `_ =` alone is not sufficient either — the
discard and the directive are both required, matching the convention already
used elsewhere in the tree.
One further finding came only from golangci-lint's gosec, whose rule set
differs from the standalone binary: G705 "XSS" on a CLI writing an unknown
subcommand to stderr through %q. Annotated — there is no HTML sink there.1 parent aef80d2 commit ed2dbff
2 files changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
| 73 | + | |
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
202 | 202 | | |
203 | 203 | | |
204 | 204 | | |
205 | | - | |
206 | | - | |
| 205 | + | |
| 206 | + | |
207 | 207 | | |
208 | 208 | | |
209 | 209 | | |
| |||
0 commit comments