PA Review: Decks

[xnanodax]

• Backend: DB, model, controller, views
• Redux Loop: ajax, actions, reducer
• Presentational Components
• Adequate styling
• Smooth, bug-free navigation
• Seeded with info to demonstrate this feature

[xnanodax]

• when deleting a deck, redirect the show page back to the feed page.

[LochandQuay]

@xnanodax

Console Errors:

• Warning: You tried to redirect to the same route you're currently on: "/login"

Functionality Issues:

• When I submit an invalid card (completely blank), the error flashes and it redirects to the deck page anyway.
• Okay this is actually a problem. It looks like it's consistently trying to redirect me back to /login while I'm adding cards to my deck.
• After creating a new deck, it should redirect to the new deck's display page.
• Ghosting between decks: When I created a new deck, the space to the right where the deck displays was blank. When I clicked on the new deck, there's a flicker of the old deck I was viewing.
• Should probably have a confirmation before deleting the deck, since so much work goes into it and it's irreversible.

Styling Issues:

• Adding a new card styling needs work. I'd almost prefer for it all to be on the same page, and when you add a new card, it just creates a new blank line at the bottom of the list of cards.
• Once you start to add a few cards, the "Add card" bit gets squished down at the bottom. The container could probably use some padding or something so it has some space.
• Same note on the add new deck form. It need more styling. Should probably be centered on the space to the right of the index.

[xnanodax]

I love the idea of adding more cards to the bottom of the card list. How do I manipulate the document to do that?

[xnanodax]

Instead of going to a new card container, I added cards to the bottom of the deck with a default fields "tap to edit"