Skip to content

[BUG] Opening banner sits too low and "Opening" text is clipped at the bottom #571

Description

@tramch

Describe the bug
When opening a book from the ZenOS library, the black "Opening" banner that appears briefly at the bottom of the screen sits too close to the bottom edge.

On my Kindle Colorsoft, the bottom of the "Opening" text is slightly cut off.

This is the full-width opening banner shown before the book opens, not the banner displayed over the book cover.

To Reproduce
Steps to reproduce the behavior:

  1. Open the ZenOS Library.
  2. Tap a book to open it.
  3. Observe the black "Opening" banner at the bottom of the screen.
  4. Notice that the banner sits flush against the bottom edge and the "Opening" text is slightly clipped at the bottom.

Expected behavior
The opening banner should have a small margin/inset from the bottom of the screen so that the banner and its text are fully visible.

Screenshots
I can provide a screenshot showing the issue.

Logs
N/A - no crash occurs.

Please complete the following information:

  • Device/OS: Kindle Colorsoft, Kindle firmware 5.19.6
  • KOReader version: [fill in]
  • App Version: [ZenOS version]
  • Language: en

Additional context
This appears to be related to the fallback/full-width opening banner positioning.

The current positioning appears to place the banner directly against the bottom of the screen:

by = Screen:getHeight() - banner_h

A small scaled bottom margin may solve the issue, for example:

local bottom_margin = Screen:scaleBySize(8)
by = Screen:getHeight() - banner_h - bottom_margin

The exact margin could of course be adjusted to fit ZenOS's existing layout conventions.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions