Skip to content

Thanks for the provenance note β€” one small MIT notice gap in the shipped buildΒ #26

Description

@hifihedgehog

Hi! πŸ‘‹ HIDMaestro author here (Hifihedgehog).

First off, thank you for the writeup in crates/hidmaestro/driver/README.md. Naming the source repo, the exact release (v1.3.17), the MIT license, and being upfront that the binaries were extracted from the DriverStore copy is genuinely more provenance care than most projects bother with, and I appreciate it. The node-graph approach in FlexInput is really cool, too.

One small licensing gap, and it's an easy fix. The MIT license asks that the copyright line and permission notice travel with every copy of the software, and flexinput.exe embeds the driver package via include_bytes! (HIDMaestro.dll, HMXInput.dll, both INFs, both catalogs), so each release is a copy. Right now the notice text itself isn't anywhere β€” not in the repo, and the release zip is just the single exe with no license files.

Concretely, either of these closes it:

  • Drop HIDMaestro's LICENSE into crates/hidmaestro/driver/ next to the binaries (the same treatment vendor/egui-snarl/ already gets), and
  • Include a THIRD-PARTY-NOTICES.txt (or equivalent) beside flexinput.exe in the release zip so it ships with the built artifact.

A line in the main README's Credits section would be a nice touch as well, though that one's courtesy rather than license.

Totally happy to help on the technical side too, whenever useful. You're pinned to v1.3.17 and current is v1.6.x, and there's been a fair amount since then (USB/IP backend, more profiles, FFB fixes). If anything in the shared-memory protocol or the XUSB companion path gives you trouble as you move forward, open a thread on the HIDMaestro repo (https://github.com/hifihedgehog/HIDMaestro) or ping me and I'll help however I can.

Thanks again for building on it, and for the honest provenance note. πŸ™

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions