From 78117c5086d57dcec42006c6da838c4f816f2374 Mon Sep 17 00:00:00 2001 From: whereareiam Date: Sun, 4 Oct 2026 10:52:04 +0200 Subject: [PATCH] Pull request: Stop the merge menu jumping, keep the header still between tabs, tidy the reviewer row - A pressed button is briefly transformed, which made the merge arrow the positioning parent of its own menu: the menu opened under the arrow and jumped left when the press transition ended. Buttons that hold a dropdown no longer transform. - The title header had 4px extra padding and a different gap on Commits and Files changed than on Conversation, so switching tabs moved the page. All tabs now share one header box. - A reviewer's row in the sidebar shows the name in bold with 16px muted action icons instead of mixed sizes in the text colour. Co-Authored-By: Claude Opus 5.5 --- styles/components/issues/issue_conversation.ts | 18 ++++++++++++++++++ styles/components/issues/pull_review.ts | 6 ++++++ styles/public/transition.ts | 5 +++++ 3 files changed, 29 insertions(+) diff --git a/styles/components/issues/issue_conversation.ts b/styles/components/issues/issue_conversation.ts index 5227cefa..43bea323 100644 --- a/styles/components/issues/issue_conversation.ts +++ b/styles/components/issues/issue_conversation.ts @@ -134,6 +134,24 @@ export default css` gap: 4px; padding: 0; } + /* A reviewer's row: the name, then small muted actions and the review state. */ + & .assignees .item .sidebar-item-link { + font-weight: 600; + } + & .assignees .item :is(.show-modal, .re-request-review) { + display: grid; + place-items: center; + width: 16px; + height: 16px; + color: ${themeVars.color.text.light.num1}; + &:hover { + color: ${themeVars.github.fgColor.accent}; + } + } + & .assignees .item svg { + width: 16px; + height: 16px; + } & .watching .ui.button { height: 28px; padding: 3px 8px; diff --git a/styles/components/issues/pull_review.ts b/styles/components/issues/pull_review.ts index c9734561..9e2b2501 100644 --- a/styles/components/issues/pull_review.ts +++ b/styles/components/issues/pull_review.ts @@ -54,8 +54,14 @@ export default css` margin-left: auto; margin-right: auto; } + /* The same header box on every tab, so switching tabs does not move the page. */ & .issue-title-header { margin-bottom: 16px; + padding: 0; + } + & .issue-title { + align-items: flex-start; + gap: 16px; } & .issue-title h1 { font-size: 32px; diff --git a/styles/public/transition.ts b/styles/public/transition.ts index b4dd4f2e..5eda4d55 100644 --- a/styles/public/transition.ts +++ b/styles/public/transition.ts @@ -93,6 +93,11 @@ const transition = css` &.dropdown { z-index: 1; } + /* A transformed button becomes the positioning parent of its own menu, so the menu + opened under the button and jumped once the press transition ended. */ + &.dropdown:active { + transform: none; + } .button:active { transform: none; }