[WV-2599] Fix fragile styled-components selector in FAQ page title Element#4833
Draft
tarunramireddy wants to merge 3 commits into
Draft
[WV-2599] Fix fragile styled-components selector in FAQ page title Element#4833tarunramireddy wants to merge 3 commits into
tarunramireddy wants to merge 3 commits into
Conversation
…ement Replace auto-generated CSS class .kkIyuQ with stable text-based selector so the test does not break when styled-components regenerates class names on each build.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the FAQ page object to locate the page title using a more semantic selector rather than a generated CSS class.
Changes:
- Replaces a CSS class selector for the FAQ page title with an element/text-based selector.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Remove it.only from verifyGitHubLinkRedirected so all three tests run - Add missing getTermsLinkElement getter to ReadyPage using #footerLinkTermsOfUse - Add missing pageContentTitleText getter to PrivacyPage using stable h1 text selector
- Remove driver.switchWindow() calls for in-page SPA navigation (value pages open in same tab, not new window) - Add window.scrollTo(0,0) before avatar sign-out click in endorsers tests (page is deeply scrolled after scrollIntoView on showMoreItemsId) - Use waitForClickable with 30s timeout for avatar after endorsers section (OrganizationList re-render after loading all endorsers takes longer than default 10s) - Remove duplicate class body from ready.browser.js that contained a broken login() using #emailVerifyButton instead of #phoneVerifyButton
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github.com/wevote/WebApp/issues does this fix?
WV-2599 — Regression run failure analysis and fixes for FAQ, Terms page, and VerifyCount
Changes included this pull request?