WV-2472: Fix the More menu toggle and close the gap above the footer (mobile)#4830
Open
0x416c616e wants to merge 1 commit into
Open
WV-2472: Fix the More menu toggle and close the gap above the footer (mobile)#48300x416c616e wants to merge 1 commit into
0x416c616e wants to merge 1 commit into
Conversation
…er on mobile Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The More button didn't toggle as expected because the
ClickAwayListenerand the More button'sonChangetoggle were both triggering on the same click — the menu would close and immediately reopen, making it look like it wasn't closing at all.I put the More button's
anchorRefintoMoreMenuOverlayand made theClickAwayListenerignore clicks when the target is inside the anchor, so the button'sonChangeis the sole toggler.Also closed the small CSS gap between the expanded More menu and the footer below it by aligning the menu's bottom edge to the footer height (and removing a leftover
translateYnudge).