Wetling23,
I have really enjoyed and loved using the Logic Monitor PS Module that you've built out. I do have a couple of issues and suggestions, and will be providing some examples of how some of the module framework can be simplified:
Main focuses would be the authentication:
- Each function has a common authentication and construction template, this would best be resolved by migrating this to a private function that handles the authentication and passes into the running script. (Will provide an example soon)
- Complicated Logging Function Inserts
Each Function in the module has a verbose writescape of logging in each function. This is also a repeated template framework that can be shrunken down into a private function that handles the logging processors.
I hope to provide an example soon, but did want to get feedback on this.
Wetling23,
I have really enjoyed and loved using the Logic Monitor PS Module that you've built out. I do have a couple of issues and suggestions, and will be providing some examples of how some of the module framework can be simplified:
Main focuses would be the authentication:
Each Function in the module has a verbose writescape of logging in each function. This is also a repeated template framework that can be shrunken down into a private function that handles the logging processors.
I hope to provide an example soon, but did want to get feedback on this.