From 130fd5667ba786e1b8c276bb5bd6a1809524453b Mon Sep 17 00:00:00 2001 From: dommi22m Date: Mon, 15 Aug 2022 13:20:14 +0200 Subject: [PATCH 1/4] Made SNMP privacy protocol selectable --- check_synology.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/check_synology.py b/check_synology.py index 5947baf..bee6639 100755 --- a/check_synology.py +++ b/check_synology.py @@ -19,6 +19,7 @@ parser.add_argument("-w", help="warning value for selected mode", type=int) parser.add_argument("-c", help="critical value for selected mode", type=int) parser.add_argument("-p", help="the snmp port", type=int, dest="port", default=161) +parser.add_argument("-s", help="SNMP privacy protocol", type=str, default="AES128", choices=["AES128", "DES"]) args = parser.parse_args() hostname = args.hostname @@ -29,6 +30,7 @@ mode = args.mode warning = args.w critical = args.c +priv_protocol = args.s state = 'OK' @@ -51,7 +53,7 @@ def croak(message=None): auth_password=auth_key, auth_protocol="MD5", privacy_password=priv_key, - privacy_protocol="AES128") + privacy_protocol=priv_protocol) except Exception as e: croak(e) From c8f9ce77102e9520c0cfa578ec12a45c26189792 Mon Sep 17 00:00:00 2001 From: dommi22m Date: Tue, 16 Aug 2022 10:06:38 +0200 Subject: [PATCH 2/4] Change name of command line parameter --- check_synology.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/check_synology.py b/check_synology.py index bee6639..f18f003 100755 --- a/check_synology.py +++ b/check_synology.py @@ -19,7 +19,7 @@ parser.add_argument("-w", help="warning value for selected mode", type=int) parser.add_argument("-c", help="critical value for selected mode", type=int) parser.add_argument("-p", help="the snmp port", type=int, dest="port", default=161) -parser.add_argument("-s", help="SNMP privacy protocol", type=str, default="AES128", choices=["AES128", "DES"]) +parser.add_argument("-e", help="SNMP privacy protocol encryption", type=str, default="AES128", choices=["AES128", "DES"]) args = parser.parse_args() hostname = args.hostname @@ -30,7 +30,7 @@ mode = args.mode warning = args.w critical = args.c -priv_protocol = args.s +priv_protocol = args.e state = 'OK' From 478e507cc50955ea465e13aa1f29f0523df540b1 Mon Sep 17 00:00:00 2001 From: dommi22m Date: Tue, 16 Aug 2022 10:10:29 +0200 Subject: [PATCH 3/4] ADD command line parameter for privacy protocol --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index a04fe8d..87d7199 100644 --- a/README.md +++ b/README.md @@ -34,10 +34,11 @@ check_synology --help ```shell check_synology -usage: check_synology [-h] [-w W] [-c C] [-p PORT] hostname username authkey privkey {load,memory,disk,storage,update,status} +usage: check_synology [-h] [-w W] [-c C] [-p PORT] [-e PROTOCOL ] hostname username authkey privkey {load,memory,disk,storage,update,status} ``` A custom port can be specified by using `-p`. The default value is `161`. +A custom privacy protocol can be specified by using `-e`. The default value is `AES128`. ### Available modes From 557f52003631daa033a702d46e4e18c3f495eeb0 Mon Sep 17 00:00:00 2001 From: Frederic Werner <20406381+wernerfred@users.noreply.github.com> Date: Mon, 8 Jan 2024 14:49:41 +0100 Subject: [PATCH 4/4] docs: remove additional whitespace --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 87d7199..61df139 100644 --- a/README.md +++ b/README.md @@ -34,7 +34,7 @@ check_synology --help ```shell check_synology -usage: check_synology [-h] [-w W] [-c C] [-p PORT] [-e PROTOCOL ] hostname username authkey privkey {load,memory,disk,storage,update,status} +usage: check_synology [-h] [-w W] [-c C] [-p PORT] [-e PROTOCOL] hostname username authkey privkey {load,memory,disk,storage,update,status} ``` A custom port can be specified by using `-p`. The default value is `161`.