From 571910fc0418eb4b1c850c881bd3d6a215afef99 Mon Sep 17 00:00:00 2001
From: WebDevNerdStuff <webdevnerdstuff@gmail.com>
Date: Wed, 22 Jul 2026 11:47:49 -0400
Subject: [PATCH 1/2] fix premature validation so required select fields don't
 error on open

---
 .../fields/CommonField/CommonField.vue        | 29 +++++-
 .../__tests__/CommonFieldValidation.cy.ts     | 94 +++++++++++++++++++
 .../fields/VSFButtonField/VSFButtonField.vue  |  1 +
 .../fields/VSFCheckbox/VSFCheckbox.vue        |  1 +
 .../components/fields/VSFCustom/VSFCustom.vue |  1 +
 .../components/fields/VSFRadio/VSFRadio.vue   |  1 +
 6 files changed, 126 insertions(+), 1 deletion(-)
 create mode 100644 src/plugin/components/fields/CommonField/__tests__/CommonFieldValidation.cy.ts

diff --git a/src/plugin/components/fields/CommonField/CommonField.vue b/src/plugin/components/fields/CommonField/CommonField.vue
index f707304..3b88c89 100644
--- a/src/plugin/components/fields/CommonField/CommonField.vue
+++ b/src/plugin/components/fields/CommonField/CommonField.vue
@@ -7,9 +7,10 @@
 		:error="hasErrors"
 		:error-messages="errorMessage || field.errorMessages"
 		:items="fieldItems"
-		@blur="fieldValidateOn === 'blur' ? onActions('blur') : undefined"
 		@change="fieldValidateOn === 'change' ? onActions('change') : undefined"
 		@input="fieldValidateOn === 'input' ? onActions('input') : undefined"
+		@update:focused="onFocusUpdate"
+		@update:menu="onMenuUpdate"
 	>
 		<template #label>
 			<FieldLabel
@@ -52,6 +53,7 @@ const { errorMessage, setValue, validate, value } = useField(
 		validateOnChange: fieldValidateOn.value === 'change',
 		validateOnInput: fieldValidateOn.value === 'input',
 		validateOnModelUpdate: fieldValidateOn.value != null,
+		validateOnValueUpdate: fieldValidateOn.value === 'input' || fieldValidateOn.value === 'change',
 	},
 );
 
@@ -63,6 +65,31 @@ onUnmounted(() => {
 });
 
 
+// ------------------------- Menu-aware blur validation //
+// Overlay fields (select/autocomplete/combobox/date/color) emit `update:focused`
+// false the moment their menu opens, because focus moves into the overlay list.
+// Validating on that raw blur would flag a required field as invalid the instant
+// the user opens it. To avoid that we:
+//   - skip the blur validation while the menu is open, and
+//   - validate when the menu closes (the real "done with the field" signal).
+// Menu-less fields (text/textarea/number) never emit `update:menu`, so they fall
+// back to plain blur validation via onFocusUpdate.
+const isMenuOpen = ref(false);
+
+function onMenuUpdate(open: boolean): void {
+	isMenuOpen.value = open;
+
+	if (fieldValidateOn.value === 'blur' && !open) {
+		onActions('blur');
+	}
+}
+
+function onFocusUpdate(isFocused: boolean): void {
+	if (fieldValidateOn.value === 'blur' && !isFocused && !isMenuOpen.value) {
+		onActions('blur');
+	}
+}
+
 // ------------------------- Validate On Actions //
 async function onActions(action: ValidateAction): Promise<void> {
 	await useOnActions({
diff --git a/src/plugin/components/fields/CommonField/__tests__/CommonFieldValidation.cy.ts b/src/plugin/components/fields/CommonField/__tests__/CommonFieldValidation.cy.ts
new file mode 100644
index 0000000..8a801d3
--- /dev/null
+++ b/src/plugin/components/fields/CommonField/__tests__/CommonFieldValidation.cy.ts
@@ -0,0 +1,94 @@
+import * as DATA from '@cypress/templates/testData';
+import { object as yupObject, string as yupString } from 'yup';
+import VStepperForm from '../../../../VStepperForm.vue';
+
+
+// Regression coverage for menu-aware blur validation.
+// A required select must NOT be flagged as invalid simply because the user
+// opened its menu (opening moves focus into the overlay and emits a blur).
+// See CommonField.vue > onFocusUpdate / onMenuUpdate.
+
+const requiredMessage = DATA.isRequired('Select Animal');
+
+const pages = [
+	{
+		fields: [DATA.defaultFields.select],
+		title: 'Select Page',
+	},
+];
+
+const validationSchema = yupObject({
+	selectAnimal: yupString().required(requiredMessage),
+});
+
+function mountForm(): void {
+	cy.mount(VStepperForm as any, {
+		props: {
+			modelValue: { selectAnimal: null },
+			pages,
+			validateOn: 'blur',
+			validationSchema,
+		},
+	});
+
+	cy.getDataCy('vsf-field-selectAnimal').as('select');
+}
+
+function openMenu(): void {
+	cy.get('@select')
+		.find('.v-field')
+		.invoke('attr', 'aria-controls')
+		.as('menuId');
+
+	cy.get('@select').click();
+}
+
+
+describe('CommonField validation (validateOn="blur")', () => {
+
+	it('does not error when a required select menu is merely opened', () => {
+		mountForm();
+		openMenu();
+
+		// Menu is open and its items are visible.
+		cy.get('@menuId').then((menuId) => {
+			cy.get(`#${menuId}`).find('.v-list-item').should('exist');
+		});
+
+		// Wait past the ~250ms menu-open blur that used to trigger premature
+		// validation, then confirm the field is still clean.
+		// eslint-disable-next-line cypress/no-unnecessary-waiting
+		cy.wait(500);
+		cy.get('@select').should('not.have.class', 'v-input--error');
+		cy.get('@select').find('.v-messages__message').should('not.exist');
+	});
+
+	it('errors when a required select is closed without a selection', () => {
+		mountForm();
+		openMenu();
+
+		// Close the menu without choosing anything (click outside).
+		cy.get('.v-application__wrap').click();
+
+		cy.get('@select').should('have.class', 'v-input--error');
+		cy.get('@select')
+			.find('.v-messages__message')
+			.should('contain', requiredMessage);
+	});
+
+	it('stays valid after selecting a value and closing the menu', () => {
+		mountForm();
+		openMenu();
+
+		cy.get('@menuId').then((menuId) => {
+			cy.get(`#${menuId}`)
+				.find('.v-list-item')
+				.contains('.v-list-item', 'Rabbit')
+				.click();
+		});
+
+		cy.get('@select').should('not.have.class', 'v-input--error');
+		cy.get('@select').find('.v-messages__message').should('not.exist');
+	});
+
+});
diff --git a/src/plugin/components/fields/VSFButtonField/VSFButtonField.vue b/src/plugin/components/fields/VSFButtonField/VSFButtonField.vue
index 4590de7..1dd8786 100644
--- a/src/plugin/components/fields/VSFButtonField/VSFButtonField.vue
+++ b/src/plugin/components/fields/VSFButtonField/VSFButtonField.vue
@@ -119,6 +119,7 @@ const { errorMessage, handleChange, setValue, validate, value } = useField(
 		validateOnChange: fieldValidateOn.value === 'change',
 		validateOnInput: fieldValidateOn.value === 'input',
 		validateOnModelUpdate: fieldValidateOn.value != null,
+		validateOnValueUpdate: fieldValidateOn.value === 'input' || fieldValidateOn.value === 'change',
 	},
 );
 
diff --git a/src/plugin/components/fields/VSFCheckbox/VSFCheckbox.vue b/src/plugin/components/fields/VSFCheckbox/VSFCheckbox.vue
index 8cec295..cc33601 100644
--- a/src/plugin/components/fields/VSFCheckbox/VSFCheckbox.vue
+++ b/src/plugin/components/fields/VSFCheckbox/VSFCheckbox.vue
@@ -127,6 +127,7 @@ const { errorMessage, setValue, validate, value } = useField(
 		validateOnChange: fieldValidateOn.value === 'change',
 		validateOnInput: fieldValidateOn.value === 'input',
 		validateOnModelUpdate: fieldValidateOn.value != null,
+		validateOnValueUpdate: fieldValidateOn.value === 'input' || fieldValidateOn.value === 'change',
 	},
 );
 
diff --git a/src/plugin/components/fields/VSFCustom/VSFCustom.vue b/src/plugin/components/fields/VSFCustom/VSFCustom.vue
index 97828ae..6f6c2e2 100644
--- a/src/plugin/components/fields/VSFCustom/VSFCustom.vue
+++ b/src/plugin/components/fields/VSFCustom/VSFCustom.vue
@@ -57,6 +57,7 @@ const $useField = useField(
 		validateOnChange: fieldValidateOn.value === 'change',
 		validateOnInput: fieldValidateOn.value === 'input',
 		validateOnModelUpdate: fieldValidateOn.value != null,
+		validateOnValueUpdate: fieldValidateOn.value === 'input' || fieldValidateOn.value === 'change',
 	},
 );
 
diff --git a/src/plugin/components/fields/VSFRadio/VSFRadio.vue b/src/plugin/components/fields/VSFRadio/VSFRadio.vue
index f4c1a9c..9a9370b 100644
--- a/src/plugin/components/fields/VSFRadio/VSFRadio.vue
+++ b/src/plugin/components/fields/VSFRadio/VSFRadio.vue
@@ -109,6 +109,7 @@ const { errorMessage, setValue, validate, value } = useField(
 		validateOnChange: fieldValidateOn.value === 'change',
 		validateOnInput: fieldValidateOn.value === 'input',
 		validateOnModelUpdate: fieldValidateOn.value != null,
+		validateOnValueUpdate: fieldValidateOn.value === 'input' || fieldValidateOn.value === 'change',
 	},
 );
 

From 21dd7e26d45b452688b0f25d22ac9733357bb21f Mon Sep 17 00:00:00 2001
From: WebDevNerdStuff <webdevnerdstuff@gmail.com>
Date: Wed, 22 Jul 2026 14:55:30 -0400
Subject: [PATCH 2/2] refactor(fields): drop no-op useField validateOn options
 and add checkbox/radio validation tests

---
 .../fields/CommonField/CommonField.vue        |  4 -
 .../fields/VSFButtonField/VSFButtonField.vue  |  4 -
 .../fields/VSFCheckbox/VSFCheckbox.vue        |  4 -
 .../__tests__/VSFCheckboxValidation.cy.ts     | 79 +++++++++++++++++++
 .../components/fields/VSFCustom/VSFCustom.vue |  4 -
 .../components/fields/VSFRadio/VSFRadio.vue   |  4 -
 .../__tests__/VSFRadioValidation.cy.ts        | 76 ++++++++++++++++++
 7 files changed, 155 insertions(+), 20 deletions(-)
 create mode 100644 src/plugin/components/fields/VSFCheckbox/__tests__/VSFCheckboxValidation.cy.ts
 create mode 100644 src/plugin/components/fields/VSFRadio/__tests__/VSFRadioValidation.cy.ts

diff --git a/src/plugin/components/fields/CommonField/CommonField.vue b/src/plugin/components/fields/CommonField/CommonField.vue
index 3b88c89..639fb24 100644
--- a/src/plugin/components/fields/CommonField/CommonField.vue
+++ b/src/plugin/components/fields/CommonField/CommonField.vue
@@ -49,10 +49,6 @@ const { errorMessage, setValue, validate, value } = useField(
 	undefined,
 	{
 		initialValue: modelValue.value,
-		validateOnBlur: fieldValidateOn.value === 'blur',
-		validateOnChange: fieldValidateOn.value === 'change',
-		validateOnInput: fieldValidateOn.value === 'input',
-		validateOnModelUpdate: fieldValidateOn.value != null,
 		validateOnValueUpdate: fieldValidateOn.value === 'input' || fieldValidateOn.value === 'change',
 	},
 );
diff --git a/src/plugin/components/fields/VSFButtonField/VSFButtonField.vue b/src/plugin/components/fields/VSFButtonField/VSFButtonField.vue
index 1dd8786..144066a 100644
--- a/src/plugin/components/fields/VSFButtonField/VSFButtonField.vue
+++ b/src/plugin/components/fields/VSFButtonField/VSFButtonField.vue
@@ -115,10 +115,6 @@ const { errorMessage, handleChange, setValue, validate, value } = useField(
 	undefined,
 	{
 		initialValue: field.value?.multiple ? [] : null,
-		validateOnBlur: fieldValidateOn.value === 'blur',
-		validateOnChange: fieldValidateOn.value === 'change',
-		validateOnInput: fieldValidateOn.value === 'input',
-		validateOnModelUpdate: fieldValidateOn.value != null,
 		validateOnValueUpdate: fieldValidateOn.value === 'input' || fieldValidateOn.value === 'change',
 	},
 );
diff --git a/src/plugin/components/fields/VSFCheckbox/VSFCheckbox.vue b/src/plugin/components/fields/VSFCheckbox/VSFCheckbox.vue
index cc33601..7ac5059 100644
--- a/src/plugin/components/fields/VSFCheckbox/VSFCheckbox.vue
+++ b/src/plugin/components/fields/VSFCheckbox/VSFCheckbox.vue
@@ -123,10 +123,6 @@ const { errorMessage, setValue, validate, value } = useField(
 	undefined,
 	{
 		initialValue: modelValue.value,
-		validateOnBlur: fieldValidateOn.value === 'blur',
-		validateOnChange: fieldValidateOn.value === 'change',
-		validateOnInput: fieldValidateOn.value === 'input',
-		validateOnModelUpdate: fieldValidateOn.value != null,
 		validateOnValueUpdate: fieldValidateOn.value === 'input' || fieldValidateOn.value === 'change',
 	},
 );
diff --git a/src/plugin/components/fields/VSFCheckbox/__tests__/VSFCheckboxValidation.cy.ts b/src/plugin/components/fields/VSFCheckbox/__tests__/VSFCheckboxValidation.cy.ts
new file mode 100644
index 0000000..bda686c
--- /dev/null
+++ b/src/plugin/components/fields/VSFCheckbox/__tests__/VSFCheckboxValidation.cy.ts
@@ -0,0 +1,79 @@
+import * as DATA from '@cypress/templates/testData';
+import { object as yupObject, string as yupString } from 'yup';
+import VStepperForm from '../../../../VStepperForm.vue';
+
+
+// Validation-timing coverage for the single checkbox field.
+// A menu-less field has no overlay, so it cannot suffer the "errors on open"
+// bug the select had. What we verify instead is that toggling the box drives
+// validation at the right moment (via onActions('click')) and that the field
+// is not flagged before the user interacts with it.
+// See VSFCheckbox.vue > onActions and the useField `validateOnValueUpdate`.
+
+const requiredMessage = DATA.isRequired('Checkbox Single');
+const mustBeCheckedMessage = 'The box must be checked';
+
+const pages = [
+	{
+		fields: [DATA.defaultFields.checkbox],
+		title: 'Checkbox Page',
+	},
+];
+
+// A Vuetify single checkbox with `true-value: 'yes'` and no `false-value`
+// resolves to `false` when unchecked, so `required()` alone would treat the
+// unchecked state as valid (yup casts `false` -> "false"). `oneOf(['yes'])`
+// lets us assert that the commit click actually re-runs validation.
+const validationSchema = yupObject({
+	isThisBoxChecked: yupString()
+		.required(requiredMessage)
+		.oneOf(['yes'], mustBeCheckedMessage),
+});
+
+function mountForm(validateOn: 'blur' | 'change'): void {
+	cy.mount(VStepperForm as any, {
+		props: {
+			modelValue: { isThisBoxChecked: null },
+			pages,
+			validateOn,
+			validationSchema,
+		},
+	});
+
+	cy.getDataCy('vsf-field-isThisBoxChecked').as('checkbox');
+}
+
+
+for (const validateOn of ['blur', 'change'] as const) {
+	describe(`VSFCheckbox validation (validateOn="${validateOn}")`, () => {
+
+		it('is not flagged before the user interacts with it', () => {
+			mountForm(validateOn);
+
+			cy.get('@checkbox').should('not.have.class', 'v-input--error');
+			cy.get('@checkbox').find('.v-messages__message').should('not.exist');
+		});
+
+		it('stays valid after checking the box', () => {
+			mountForm(validateOn);
+
+			cy.get('@checkbox').find('input').click();
+
+			cy.get('@checkbox').should('not.have.class', 'v-input--error');
+			cy.get('@checkbox').find('.v-messages__message').should('not.exist');
+		});
+
+		it('re-validates and errors after the box is checked then unchecked', () => {
+			mountForm(validateOn);
+
+			cy.get('@checkbox').find('input').click();
+			cy.get('@checkbox').find('input').click();
+
+			cy.get('@checkbox').should('have.class', 'v-input--error');
+			cy.get('@checkbox')
+				.find('.v-messages__message')
+				.should('contain', mustBeCheckedMessage);
+		});
+
+	});
+}
diff --git a/src/plugin/components/fields/VSFCustom/VSFCustom.vue b/src/plugin/components/fields/VSFCustom/VSFCustom.vue
index 6f6c2e2..aea526a 100644
--- a/src/plugin/components/fields/VSFCustom/VSFCustom.vue
+++ b/src/plugin/components/fields/VSFCustom/VSFCustom.vue
@@ -53,10 +53,6 @@ const $useField = useField(
 	undefined,
 	{
 		initialValue: modelValue.value,
-		validateOnBlur: fieldValidateOn.value === 'blur',
-		validateOnChange: fieldValidateOn.value === 'change',
-		validateOnInput: fieldValidateOn.value === 'input',
-		validateOnModelUpdate: fieldValidateOn.value != null,
 		validateOnValueUpdate: fieldValidateOn.value === 'input' || fieldValidateOn.value === 'change',
 	},
 );
diff --git a/src/plugin/components/fields/VSFRadio/VSFRadio.vue b/src/plugin/components/fields/VSFRadio/VSFRadio.vue
index 9a9370b..ee9780b 100644
--- a/src/plugin/components/fields/VSFRadio/VSFRadio.vue
+++ b/src/plugin/components/fields/VSFRadio/VSFRadio.vue
@@ -105,10 +105,6 @@ const { errorMessage, setValue, validate, value } = useField(
 	{
 		initialValue: modelValue.value,
 		type: 'radio',
-		validateOnBlur: fieldValidateOn.value === 'blur',
-		validateOnChange: fieldValidateOn.value === 'change',
-		validateOnInput: fieldValidateOn.value === 'input',
-		validateOnModelUpdate: fieldValidateOn.value != null,
 		validateOnValueUpdate: fieldValidateOn.value === 'input' || fieldValidateOn.value === 'change',
 	},
 );
diff --git a/src/plugin/components/fields/VSFRadio/__tests__/VSFRadioValidation.cy.ts b/src/plugin/components/fields/VSFRadio/__tests__/VSFRadioValidation.cy.ts
new file mode 100644
index 0000000..ba8b5df
--- /dev/null
+++ b/src/plugin/components/fields/VSFRadio/__tests__/VSFRadioValidation.cy.ts
@@ -0,0 +1,76 @@
+import * as DATA from '@cypress/templates/testData';
+import { object as yupObject, string as yupString } from 'yup';
+import VStepperForm from '../../../../VStepperForm.vue';
+
+
+// Validation-timing coverage for the single radio field.
+// Radio is menu-less, so it can't hit the select "errors on open" bug. It also
+// never returns to an empty state once a value is picked, so we exercise the
+// schema's `matches(/(yes|no)/)` rule: picking "Maybe" must flag the field the
+// moment it is selected, and picking a valid option must clear it.
+// See VSFRadio.vue > onActions and the useField `validateOnValueUpdate`.
+
+const requiredMessage = DATA.isRequired('Radio Single');
+const matchesMessage = 'Only "yes" or "no" is allowed';
+
+const pages = [
+	{
+		fields: [DATA.defaultFields.radio],
+		title: 'Radio Page',
+	},
+];
+
+const validationSchema = yupObject({
+	isSingleRadioSelected: yupString()
+		.required(requiredMessage)
+		.matches(/(yes|no)/, matchesMessage),
+});
+
+function mountForm(validateOn: 'blur' | 'change'): void {
+	cy.mount(VStepperForm as any, {
+		props: {
+			modelValue: { isSingleRadioSelected: null },
+			pages,
+			validateOn,
+			validationSchema,
+		},
+	});
+
+	cy.getDataCy('vsf-field-group-isSingleRadioSelected').as('radioGroup');
+}
+
+
+for (const validateOn of ['blur', 'change'] as const) {
+	describe(`VSFRadio validation (validateOn="${validateOn}")`, () => {
+
+		it('is not flagged before an option is selected', () => {
+			mountForm(validateOn);
+
+			cy.get('@radioGroup').find('.v-messages__message').should('not.exist');
+		});
+
+		it('flags an invalid option the moment it is selected', () => {
+			mountForm(validateOn);
+
+			cy.contains('.v-radio', 'Maybe').click();
+
+			cy.get('@radioGroup')
+				.find('.v-messages__message')
+				.should('contain', matchesMessage);
+		});
+
+		it('clears the error after switching to a valid option', () => {
+			mountForm(validateOn);
+
+			cy.contains('.v-radio', 'Maybe').click();
+			cy.get('@radioGroup')
+				.find('.v-messages__message')
+				.should('contain', matchesMessage);
+
+			cy.contains('.v-radio', 'Yes').click();
+
+			cy.get('@radioGroup').find('.v-messages__message').should('not.exist');
+		});
+
+	});
+}