From 9b982947322e9462ace2860fe40ea558275a046d Mon Sep 17 00:00:00 2001 From: kevin Date: Thu, 23 Jul 2026 13:52:41 -0300 Subject: [PATCH 1/6] Update referenceId in deployment.yaml Updated referenceId for pickup-points-modal in deployment configuration. Id taken here: https://darkkitchen.vtex.com/catalog/default/component/pickup-points-modal --- .vtex/deployment.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.vtex/deployment.yaml b/.vtex/deployment.yaml index 03a15ff..adfba1d 100644 --- a/.vtex/deployment.yaml +++ b/.vtex/deployment.yaml @@ -1,6 +1,7 @@ - name: pickup-points-modal referenceId: PLACEHOLDER description: SonarQube scan for pickup-points-modal + referenceId: V5G7Q14G build: provider: dkcicd pipelines: From d30a1aa9dd3b59162ab69f6ebf3356c0978b864c Mon Sep 17 00:00:00 2001 From: kevinch Date: Thu, 23 Jul 2026 13:55:19 -0300 Subject: [PATCH 2/6] chore: remove PLACEHOLDER referenceId, keep V5G7Q14G Co-Authored-By: Claude Opus 4.8 --- .vtex/deployment.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.vtex/deployment.yaml b/.vtex/deployment.yaml index adfba1d..ccaeedc 100644 --- a/.vtex/deployment.yaml +++ b/.vtex/deployment.yaml @@ -1,7 +1,6 @@ - name: pickup-points-modal - referenceId: PLACEHOLDER - description: SonarQube scan for pickup-points-modal referenceId: V5G7Q14G + description: SonarQube scan for pickup-points-modal build: provider: dkcicd pipelines: From a945009e4cc5a9e63d96e3225ddba2523a60dc7d Mon Sep 17 00:00:00 2001 From: kevin Date: Fri, 24 Jul 2026 10:05:58 -0300 Subject: [PATCH 3/6] ci: bump actions/cache v2 -> v4 (v2 is deprecated and now hard-fails) --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index bd1a904..41d3b46 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,7 +19,7 @@ jobs: - run: | yarn install --frozen-lockfile --check-files yarn --cwd react install --frozen-lockfile --check-files - - uses: actions/cache@v2 + - uses: actions/cache@v4 id: cache-build with: path: ./* @@ -30,7 +30,7 @@ jobs: needs: install steps: - name: Restore cache - uses: actions/cache@v2 + uses: actions/cache@v4 id: restore-build with: path: ./* @@ -42,7 +42,7 @@ jobs: needs: install steps: - name: Restore cache - uses: actions/cache@v2 + uses: actions/cache@v4 id: restore-build with: path: ./* From 666c885827b53d7ccd8f8f3e9f7da088cc15a352 Mon Sep 17 00:00:00 2001 From: kevinch Date: Tue, 4 Aug 2026 18:53:21 -0300 Subject: [PATCH 4/6] ci: add nodeCommands to node-ci-v2 for coverage scan Without nodeCommands, node-ci-v2 has no test step to run and Sonar never gets coverage data. --- .vtex/deployment.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.vtex/deployment.yaml b/.vtex/deployment.yaml index ccaeedc..f8d7751 100644 --- a/.vtex/deployment.yaml +++ b/.vtex/deployment.yaml @@ -8,6 +8,8 @@ parameters: sonarProjectName: pickup-points-modal nodeVersion: 20-bookworm + nodeCommands: + - run test:coverage runtime: architecture: amd64 when: From b2e60c13d985b2b8f4f7204cee19a45d8142b49b Mon Sep 17 00:00:00 2001 From: kevinch Date: Wed, 5 Aug 2026 09:22:00 -0300 Subject: [PATCH 5/6] ci: skip install lifecycle scripts to avoid phantomjs-prebuilt download phantomjs-prebuilt (pulled in transitively via nwb/karma-phantomjs-launcher, unused by the actual jest tests) tries to download and tar-extract a PhantomJS binary on postinstall. The CI image has no bzip2, so extraction fails and node-install never completes. No compiled/native deps here need install scripts to run. --- .yarnrc | 1 + 1 file changed, 1 insertion(+) create mode 100644 .yarnrc diff --git a/.yarnrc b/.yarnrc new file mode 100644 index 0000000..5455c6c --- /dev/null +++ b/.yarnrc @@ -0,0 +1 @@ +ignore-scripts true From b3a66a08a5f7697192bdac1ef071d4d75f4c13ea Mon Sep 17 00:00:00 2001 From: kevinch Date: Wed, 5 Aug 2026 09:26:09 -0300 Subject: [PATCH 6/6] ci: install react/ deps before running its tests in test:coverage node-ci-v2 only installs the root package.json; react/ has its own yarn.lock and is not a workspace, so vtex-test-tools (a react/ devDependency) was never installed before test:coverage tried to run it. --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 25aff67..18618aa 100644 --- a/package.json +++ b/package.json @@ -16,7 +16,7 @@ "lint:locales": "intl-equalizer", "lint:ts": "tsc --noEmit -p react/tsconfig.json", "test": "yarn --cwd react test", - "test:coverage": "yarn --cwd react test --coverage", + "test:coverage": "yarn --cwd react install --frozen-lockfile && yarn --cwd react test --coverage", "test:watch": "yarn --cwd react test --watch", "prepublishOnly": "npm run symlink:remove && npm run symlink && npm run build && npm run symlink:remove", "build:link": "npm link && watch 'npm run build' src",