Skip to content

Commit 0241090

Browse files
committed
fix: skip signing for CI builds
1 parent 6ee4c7e commit 0241090

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

‎.github/workflows/build-android.yml‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,8 @@ jobs:
6363

6464
- name: Restore Dependencies
6565
run: dotnet restore BrickController2/BrickController2.Android/BrickController2.Android.csproj
66-
- name: Setup Android signing
66+
- name: Setup Android signing
67+
if: github.event_name == 'release' && github.event.action == 'published'
6768
shell: bash
6869
run: (echo "${{secrets.KEYSTORE}}" | base64 --decode) > BrickController2/BrickController2.Android/keystore.jks
6970
- name: Build MAUI Android
@@ -72,14 +73,15 @@ jobs:
7273
-f net10.0-android `
7374
--no-restore `
7475
-p:ApplicationDisplayVersion="${{ env.APP_DISPLAY_VERSION }}" `
76+
-p:AndroidKeyStore=${{ github.event_name == 'release' && github.event.action == 'published' }} `
7577
-p:AndroidSigningKeyPass=${{secrets.KEYSTORE_PASSWORD}} `
7678
-p:AndroidSigningStorePass=${{secrets.KEYSTORE_PASSWORD}}
7779

7880
- name: Upload Android Artifact
7981
uses: actions/upload-artifact@v4
8082
with:
8183
name: brickcontroller-android-ci-build
82-
path: BrickController2/BrickController2.Android/bin/Release/net10.0-android/com.scn.BrickController2-Signed.apk
84+
path: BrickController2/BrickController2.Android/bin/Release/net10.0-android/*.apk
8385

8486
- name: Upload Artifact to Release
8587
if: github.event_name == 'release' && github.event.action == 'published'

‎.github/workflows/build-windows.yml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,13 @@ jobs:
7373
echo "APP_PACKAGE_VERSION=${VERSION_PARTS[0]:-0}.${VERSION_PARTS[1]:-0}.${VERSION_PARTS[2]:-0}.${VERSION_PARTS[3]:-0}" >> $GITHUB_ENV
7474
7575
- name: Decode Signing Certificate
76+
if: github.event_name == 'release' && github.event.action == 'published'
7677
run: |
7778
echo "${{ secrets.SIGNING_CERTIFICATE_BASE_64_CONTENT }}" > cert.asc
7879
certutil -decode cert.asc cert.pfx
7980
8081
- name: Install Signing Certificate
82+
if: github.event_name == 'release' && github.event.action == 'published'
8183
run: certutil -user -p ${{ secrets.SIGNING_CERTIFICATE_PASSWORD }} -Silent -importpfx cert.pfx NoRoot
8284

8385
- name: Restore Dependencies
@@ -98,7 +100,7 @@ jobs:
98100
-r win-x64 `
99101
-p:Platform=x64 `
100102
-p:GenerateAppxPackageOnBuild=true `
101-
-p:AppxPackageSigningEnabled=true `
103+
-p:AppxPackageSigningEnabled=${{ github.event_name == 'release' && github.event.action == 'published' }} `
102104
-p:PackageCertificateThumbprint=${{ secrets.SIGNING_CERTIFICATE_THUMBPRINT }}
103105

104106
- name: Upload WinUI Artifact

0 commit comments

Comments
 (0)