test: consume protected child pipe resets

Author: vitry

tests/helpers/run-child.mjs

@@ -25,6 +25,7 @@ export function runChild(command, args, options = {}) {
     child.stdout?.on('data', (chunk) => capture('stdout', chunk));
     child.stderr?.on('data', (chunk) => capture('stderr', chunk));
     if (protectedInput) {
+      child.stdio[3]?.on('error', consumePipeError); child.stdio[4]?.on('error', consumePipeError);
       child.stdio[4]?.on('data', (chunk) => capture('internal', chunk));
       child.stdio[3]?.end(`${JSON.stringify(options.input ?? {})}\n`);
     } else if (options.ordinaryInput) child.stdin?.end(JSON.stringify(options.input));
@@ -39,3 +40,5 @@ export function runChild(command, args, options = {}) {
     child.once('exit', (code, signal) => { if (!terminating) finish(null, { code, signal, stdout, stderr, internal, spawnargs: child.spawnargs, pid: child.pid }); });
   });
 }
+
+function consumePipeError() {}

tests/integration/companion.test.mjs

@@ -41,11 +41,14 @@ function run(command, args, options = {}) {
     let stdout = ''; let stderr = ''; let internal = '';
     child.stdout?.on('data', (chunk) => { stdout += chunk; }); child.stderr?.on('data', (chunk) => { stderr += chunk; });
     child.stdio[4]?.on('data', (chunk) => { internal += chunk; });
+    child.stdio[3]?.on('error', consumePipeError); child.stdio[4]?.on('error', consumePipeError);
     /** @type {import('node:stream').Writable} */ (child.stdio[3]).end(options.rawInput ?? `${JSON.stringify(options.input ?? {})}\n`);
     child.once('error', reject); child.once('exit', (code) => resolvePromise({ code, stdout, stderr, internal }));
   });
 }
 
+function consumePipeError() {}
+
 /** @param {any} context @param {string[]} args @param {NodeJS.ProcessEnv} [extraEnv] @param {Record<string,unknown>} [authorization] */
 async function companion(context, args, extraEnv = {}, authorization = { callerContext: context.caller }) {
   const result = await run(process.execPath, [cli, ...args], { cwd: context.workspace, env: { ...context.env, ...extraEnv }, input: authorization });
@@ -141,7 +144,7 @@ test('caller authorization is absent from the running process command line and p
   const context = await fixture(); const reserved = await companion(context, ['review', '--background']);
   const caller = await context.identity.createCallerContext({ sessionId: 'codex-session', turnId: 'turn-ps', workspace: context.workspace, permissionMode: 'workspace-write' });
   const child = spawn(process.execPath, [cli, 'status', reserved.json.job.id, '--wait', '--timeout-ms', '500'], { cwd: context.workspace, env: context.env, stdio: ['ignore', 'pipe', 'pipe', 'pipe', 'pipe'], shell: false });
-  let stdout = ''; let stderr = ''; let internal = ''; child.stdout?.on('data', (chunk) => { stdout += chunk; }); child.stderr?.on('data', (chunk) => { stderr += chunk; }); child.stdio[4]?.on('data', (chunk) => { internal += chunk; }); /** @type {import('node:stream').Writable} */ (child.stdio[3]).end(`${JSON.stringify({ callerContext: caller })}\n`);
+  let stdout = ''; let stderr = ''; let internal = ''; child.stdout?.on('data', (chunk) => { stdout += chunk; }); child.stderr?.on('data', (chunk) => { stderr += chunk; }); child.stdio[3]?.on('error', consumePipeError); child.stdio[4]?.on('error', consumePipeError); child.stdio[4]?.on('data', (chunk) => { internal += chunk; }); /** @type {import('node:stream').Writable} */ (child.stdio[3]).end(`${JSON.stringify({ callerContext: caller })}\n`);
   const inspected = await run('ps', ['-p', String(child.pid), '-o', 'command=']);
   assert.equal(inspected.code, 0); assert.doesNotMatch(inspected.stdout, new RegExp(caller));
   const code = await new Promise((resolvePromise, reject) => { child.once('error', reject); child.once('exit', resolvePromise); });

tests/recovery.test.mjs

@@ -327,6 +327,7 @@ test('real CLI fd4 delivery failure revokes capability and releases the writable
   const fixture = await context();
   const child = spawn(process.execPath, [companionCli, 'rescue', '--background', '--fresh', 'repair'], { cwd: fixture.workspace, env: fixture.env, stdio: ['ignore', 'pipe', 'pipe', 'pipe', 'pipe'] });
   /** @type {import('node:stream').Writable} */ (child.stdio[3]).end(`${JSON.stringify({ callerContext: fixture.callerContext })}\n`);
+  child.stdio[4].on('error', () => {});
   child.stdio[4].destroy();
   const code = await new Promise((resolve, reject) => { const timer = setTimeout(() => { child.kill('SIGKILL'); reject(new Error('companion delivery failure timed out')); }, 2_000); child.once('error', reject); child.once('exit', (value) => { clearTimeout(timer); resolve(value); }); });
   assert.notEqual(code, 0);