test: stabilize Node 22 timeout scenarios

Author: vitry

tests/fixtures/stop-gate-with-timeout.mjs

@@ -8,8 +8,5 @@ const dataRoot = process.env.PLUGIN_DATA;
 if (!dataRoot) throw new Error('PLUGIN_DATA required');
 const discoveryCode = process.env.FAKE_GATE_DISCOVERY_ERROR;
 const discoverZCode = discoveryCode ? async () => { throw Object.assign(new Error('fixture discovery failure'), { code: discoveryCode }); } : undefined;
-// Windows child startup can consume most of a 100 ms budget under CI. Keep
-// the deliberately suppressed completion as the timeout trigger while leaving
-// enough time for the fake protocol process to create its session.
-const timeoutMs = process.platform === 'win32' ? 2_000 : 100;
+const timeoutMs = 2_000;
 process.stdout.write(JSON.stringify(await runStopReviewGate(input, { dataRoot, env: process.env, timeoutMs, ...(discoverZCode ? { discoverZCode } : {}) })));

tests/hooks.test.mjs

@@ -351,10 +351,11 @@ test('Stop gate suppresses continuation/nested runs, fails open when setup is no
     const stop = stopFields(base);
     const script = name === 'timeout' ? join(root, 'tests/fixtures/stop-gate-with-timeout.mjs') : 'stop-review-gate-hook.mjs';
     const result = await runHook(script, { ...stop, hook_event_name: 'Stop', stop_hook_active: false, last_assistant_message: 'done' }, { ...env, ZCODE_PATH: fakeZCode, FAKE_ZCODE_RECORD: record, FAKE_ZCODE_GATE_RESULT: fake, ...extra }, { absolute: name === 'timeout' });
+    const calls = ['failure', 'read-failure', 'timeout'].includes(name) ? (await readFile(record, 'utf8')).trim().split('\n').filter(Boolean).map((line) => JSON.parse(line)) : [];
+    if (name === 'timeout') assert.ok(calls.some((call) => call.method === 'session/send'), 'timeout must reach the intended completion wait');
     assert.equal(result.code, 0); if (expected.decision) assert.equal(result.json.decision, expected.decision); else assert.deepEqual(result.json, expected);
     if (expected.reason) assert.equal(result.json.reason, expected.reason); if (result.json.reason) assert.ok(result.json.reason.length <= 1000);
     if (['failure', 'read-failure', 'timeout'].includes(name)) {
-      const calls = (await readFile(record, 'utf8')).trim().split('\n').filter(Boolean).map((line) => JSON.parse(line));
       assert.ok(calls.some((call) => call.method === 'session/stop'), `${name} must stop its created review session`);
     }
   });

tests/zcode-client.test.mjs

@@ -300,7 +300,7 @@ test('session/create rejects unsafe or amplified session identifiers at the ZCod
 });
 
 test('disconnect diagnostics retain only a bounded redacted stderr tail', async () => {
-  await withClient(async (client) => { await client.createSession({ workspace: '/repo' }); await assert.rejects(client.listSessions(), (error) => error.code === 'ZCODE_DISCONNECTED' && error.details.stderrTail.length <= 8192 && !error.details.stderrTail.includes('super-secret') && error.details.stderrTail.includes('[REDACTED]')); }, { FAKE_ZCODE_STDERR_BYTES: '20000', FAKE_ZCODE_STDERR_TEXT: ' token=super-secret ', FAKE_ZCODE_DISCONNECT: 'session/list' });
+  await withClient(async (client) => { await client.createSession({ workspace: '/repo' }); await assert.rejects(client.listSessions(), (error) => error.code === 'ZCODE_DISCONNECTED' && error.details.stderrTail.length <= 8192 && !error.details.stderrTail.includes('super-secret') && error.details.stderrTail.includes('[REDACTED]')); }, { FAKE_ZCODE_STDERR_BYTES: '20000', FAKE_ZCODE_STDERR_TEXT: ' token=super-secret ', FAKE_ZCODE_DISCONNECT: 'session/list' }, { requestTimeoutMs: 2_000 });
 });
 
 test('managed broker clients require an explicit stable owner credential', async () => {