Skip to content

Commit cfc5321

Browse files
committed
test(filter_repos) release xfail — full-path and trailing-slash matching fixed
why: filter_repos now matches against both r["path"].parent and r["path"], and normalizes trailing slashes, so the regression tests pass unconditionally. what: - remove @pytest.mark.xfail from test_filter_dir_exact_repo_path - remove @pytest.mark.xfail from test_filter_dir_workspace_root_trailing_slash - remove unused pytest import
1 parent 74118b9 commit cfc5321

1 file changed

Lines changed: 0 additions & 7 deletions

File tree

tests/test_repo.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
import typing as t
66

7-
import pytest
87
from libvcs import BaseSync, GitSync, HgSync, SvnSync
98
from libvcs._internal.shortcuts import create_project
109

@@ -25,9 +24,6 @@ def test_filter_dir() -> None:
2524
assert r["name"] == "kaptan"
2625

2726

28-
@pytest.mark.xfail(
29-
reason="filter_repos matches parent dir only; full paths not matched"
30-
)
3127
def test_filter_dir_exact_repo_path() -> None:
3228
"""`filter_repos` filter by exact full repo path (e.g. after zsh glob expansion)."""
3329
repo_list = filter_repos(
@@ -38,9 +34,6 @@ def test_filter_dir_exact_repo_path() -> None:
3834
assert repo_list[0]["name"] == "kaptan"
3935

4036

41-
@pytest.mark.xfail(
42-
reason="filter_repos parent-dir fnmatch fails with trailing slash",
43-
)
4437
def test_filter_dir_workspace_root_trailing_slash() -> None:
4538
"""`filter_repos` filter by workspace root path with trailing slash."""
4639
repo_list = filter_repos(

0 commit comments

Comments
 (0)