Skip to content

Commit a7fd26f

Browse files
committed
tests(fixtures) rename gitconfig param to vcs_gitconfig
why: libvcs 0.41.0 renamed the pytest plugin's `gitconfig` fixture to `vcs_gitconfig`. vcspull's three call sites must update to the new parameter name or pytest fixture resolution fails at collection. what: - conftest.py:setup() — request `vcs_gitconfig` instead of `gitconfig` - tests/test_fixtures.py — update test_home_contains_gitconfig and the embedded conftest text in test_pytester_git_commit_in_isolated_run
1 parent b084fd0 commit a7fd26f

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def add_doctest_fixtures(
3838
def setup(
3939
request: pytest.FixtureRequest,
4040
monkeypatch: pytest.MonkeyPatch,
41-
gitconfig: pathlib.Path,
41+
vcs_gitconfig: pathlib.Path,
4242
set_home: pathlib.Path,
4343
xdg_config_path: pathlib.Path,
4444
git_commit_envvars: dict[str, str],

tests/test_fixtures.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ def test_git_commit_envvars_in_environment(
3737

3838
def test_home_contains_gitconfig(
3939
set_home: pathlib.Path,
40-
gitconfig: pathlib.Path,
40+
vcs_gitconfig: pathlib.Path,
4141
) -> None:
4242
"""HOME should point to a directory containing .gitconfig."""
4343
home = os.environ.get("HOME", "")
@@ -136,7 +136,7 @@ def test_pytester_git_commit_in_isolated_run(
136136
def setup(
137137
request: pytest.FixtureRequest,
138138
monkeypatch: pytest.MonkeyPatch,
139-
gitconfig: pathlib.Path,
139+
vcs_gitconfig: pathlib.Path,
140140
set_home: pathlib.Path,
141141
git_commit_envvars: dict[str, str],
142142
) -> None:

0 commit comments

Comments
 (0)