cli(import): drop legacy --dir aliases

Author: tony

CHANGES

@@ -28,11 +28,11 @@ _Notes on upcoming releases will be added here_
 #### New command: `vcspull import` (#465)
 
 - **Manual import**: Register a single repository with `vcspull import <name> <url>`
-  - Optional `--workspace-root`/`--path` helpers for workspace-root detection (with legacy `--dir` alias)
+  - Optional `--workspace-root`/`--path` helpers for workspace-root detection
 - **Filesystem scan**: Discover and import existing repositories with `vcspull import --scan <dir>`
   - Recursively scan with `--recursive`/`-r`
   - Interactive confirmation prompt or `--yes` for unattended runs
-  - Custom workspace root with `--workspace-root` (legacy `--dir`/`--base-dir-key` aliases)
+  - Custom workspace root with `--workspace-root`
 
 #### New command: `vcspull fmt` (#465)
 

README.md

@@ -101,7 +101,7 @@ $ vcspull import my-lib https://github.com/example/my-lib.git --path ~/code/my-l
 
 - Omit `--path` to default the entry under `./`.
 - Use `--workspace-root` when you want to force a specific workspace root, e.g.
-  `--workspace-root ~/projects/libs` (the legacy `--dir` alias still works).
+  `--workspace-root ~/projects/libs`.
 - Pass `-c/--config` to import into an alternate YAML file.
 - Follow with `vcspull sync my-lib` to clone or update the working tree after registration.
 
@@ -116,8 +116,7 @@ $ vcspull import --scan ~/code --recursive
 
 The scan shows each repository before import unless you opt into `--yes`. Add
 `--workspace-root ~/code/` to pin the resulting workspace root or `--config` to
-write somewhere other than the default `~/.vcspull.yaml` (aliases `--dir` and
-`--base-dir-key` remain available for compatibility).
+write somewhere other than the default `~/.vcspull.yaml`.
 
 ### Normalize configuration files
 

docs/cli/import.md

@@ -49,8 +49,7 @@ $ vcspull import --scan ~/code --recursive
 
 - `--recursive`/`-r` searches nested directories.
 - `--workspace-root` forces all discovered repositories to use the same
-  workspace root, overriding the directory inferred from their location (the
-  legacy `--dir` and `--base-dir-key` aliases still work).
+  workspace root, overriding the directory inferred from their location.
 - `--yes`/`-y` accepts every suggestion, which is useful for unattended
   migrations.
 

docs/quickstart.md

@@ -114,8 +114,7 @@ YAML? Create a `~/.vcspull.yaml` file:
 Already have repositories cloned locally? Use
 `vcspull import --scan ~/code --recursive` to detect existing Git checkouts and
 append them to your configuration. See {ref}`cli-import` for more details and
-options such as `--workspace-root` and `--yes` for unattended runs (the legacy
-`--dir` and `--base-dir-key` aliases continue to work). After editing or
+options such as `--workspace-root` and `--yes` for unattended runs. After editing or
 importing, run `vcspull fmt --write` (documented in {ref}`cli-fmt`) to
 normalize keys and keep your configuration tidy.
 

src/vcspull/cli/_import.py

@@ -79,7 +79,6 @@ def create_import_subparser(parser: argparse.ArgumentParser) -> None:
     )
     parser.add_argument(
         "--workspace-root",
-        "--dir",
         dest="workspace_root_path",
         metavar="DIR",
         help=(
@@ -88,12 +87,6 @@ def create_import_subparser(parser: argparse.ArgumentParser) -> None:
             "When used with --scan, applies the workspace root to all discovered repos."
         ),
     )
-    parser.add_argument(
-        "--base-dir-key",
-        dest="workspace_root_path",
-        metavar="DIR",
-        help=argparse.SUPPRESS,
-    )
 
     # Filesystem scan mode
     parser.add_argument(

tests/cli/test_import.py

@@ -145,7 +145,7 @@ class ImportRepoFixture(t.NamedTuple):
             "import",
             "existing",
             "git@github.com:other/existing.git",
-            "--dir",
+            "--workspace-root",
             "~/code",
         ],
         initial_config={
@@ -961,6 +961,7 @@ def test_import_command_help(
     assert "url" in output
     assert "--path" in output
     assert "--workspace-root" in output
+    assert "--dir" not in output
     assert "--base-dir-key" not in output
     assert "--scan" in output
     assert "--config" in output