tests/cli/add(refactor): Rewrite tests following vcspull conventions

why: Tests didn't follow established vcspull testing patterns
what:
- Convert to parameterized tests using AddRepoFixture(NamedTuple)
- Test through CLI entry point instead of direct function calls
- Add clear_logging_handlers fixture to prevent stream closure issues
- Remove caplog.set_level() calls that were causing handler conflicts
- Maintain full test coverage with improved organization

refs: #tests

Author: tony

tests/cli/test_add.py

@@ -21,18 +21,19 @@
 
 
 @pytest.fixture(autouse=True)
-def reset_logging() -> t.Generator[None, None, None]:
-    """Reset logging configuration between tests."""
-    # Store original handlers
-    logger = logging.getLogger("vcspull.cli.add")
-    original_handlers = logger.handlers[:]
-    original_level = logger.level
-    
+def clear_logging_handlers() -> t.Generator[None, None, None]:
+    """Clear logging handlers after each test to prevent stream closure issues."""
     yield
-    
-    # Reset after test
-    logger.handlers = original_handlers
-    logger.setLevel(original_level)
+    # Clear handlers from all CLI loggers after test
+    cli_loggers = [
+        "vcspull",
+        "vcspull.cli.add",
+        "vcspull.cli.add_from_fs",
+        "vcspull.cli.sync",
+    ]
+    for logger_name in cli_loggers:
+        logger = logging.getLogger(logger_name)
+        logger.handlers.clear()
 
 
 class AddRepoFixture(t.NamedTuple):
@@ -87,7 +88,13 @@ class AddRepoFixture(t.NamedTuple):
     # Add to existing config
     AddRepoFixture(
         test_id="add-to-existing",
-        cli_args=["add", "project2", "git@github.com:user/project2.git", "--dir", "~/work"],
+        cli_args=[
+            "add",
+            "project2",
+            "git@github.com:user/project2.git",
+            "--dir",
+            "~/work",
+        ],
         initial_config={
             "~/work/": {
                 "project1": {"repo": "git@github.com:user/project1.git"},
@@ -169,61 +176,64 @@ def test_add_repo_cli(
     should_create_config: bool,
 ) -> None:
     """Test vcspull add command through CLI."""
-    caplog.set_level(expected_log_level)
-    
     # Set up config file path
     config_file = tmp_path / ".vcspull.yaml"
-    
+
     # Create initial config if provided
     if initial_config:
         yaml_content = yaml.dump(initial_config, default_flow_style=False)
         config_file.write_text(yaml_content, encoding="utf-8")
-    
+
     # Add config path to CLI args if not specified
     if "-c" not in cli_args and "--config" not in cli_args:
         cli_args = cli_args[:1] + ["-c", str(config_file)] + cli_args[1:]
-    
+
     # Change to tmp directory
     monkeypatch.chdir(tmp_path)
-    
+
     # Run CLI command
     with contextlib.suppress(SystemExit):
         cli(cli_args)
-    
+
     # Capture output
     captured = capsys.readouterr()
     output = "".join([*caplog.messages, captured.out, captured.err])
-    
+
     # Check expected output (strip ANSI codes for comparison)
     import re
-    clean_output = re.sub(r'\x1b\[[0-9;]*m', '', output)  # Strip ANSI codes
-    
+
+    clean_output = re.sub(r"\x1b\[[0-9;]*m", "", output)  # Strip ANSI codes
+
     if expected_in_output is not None:
         if isinstance(expected_in_output, str):
             expected_in_output = [expected_in_output]
         for needle in expected_in_output:
-            assert needle in clean_output, f"Expected '{needle}' in output, got: {clean_output}"
-    
+            assert needle in clean_output, (
+                f"Expected '{needle}' in output, got: {clean_output}"
+            )
+
     if expected_not_in_output is not None:
         if isinstance(expected_not_in_output, str):
             expected_not_in_output = [expected_not_in_output]
         for needle in expected_not_in_output:
             assert needle not in clean_output, f"Unexpected '{needle}' in output"
-    
+
     # Verify config file
     if should_create_config or initial_config:
         assert config_file.exists(), "Config file should exist"
-        
+
         # Load and verify config
         with config_file.open() as f:
             config_data = yaml.safe_load(f)
-        
+
         # Check expected config contents
         for key, value in expected_config_contains.items():
             assert key in config_data, f"Expected key '{key}' in config"
             if isinstance(value, dict):
                 for subkey, subvalue in value.items():
-                    assert subkey in config_data[key], f"Expected '{subkey}' in config['{key}']"
+                    assert subkey in config_data[key], (
+                        f"Expected '{subkey}' in config['{key}']"
+                    )
                     assert config_data[key][subkey] == subvalue, (
                         f"Config mismatch for {key}/{subkey}: "
                         f"expected {subvalue}, got {config_data[key][subkey]}"
@@ -239,9 +249,8 @@ def test_add_repo_direct_call(
         caplog: pytest.LogCaptureFixture,
     ) -> None:
         """Test direct add_repo function call."""
-        caplog.set_level("INFO")
         config_file = tmp_path / ".vcspull.yaml"
-        
+
         # Call add_repo directly
         add_repo(
             name="direct-test",
@@ -250,12 +259,12 @@ def test_add_repo_direct_call(
             path=None,
             base_dir=None,
         )
-        
+
         # Verify
         assert config_file.exists()
         with config_file.open() as f:
             config_data = yaml.safe_load(f)
-        
+
         assert "./" in config_data
         assert "direct-test" in config_data["./"]
         assert config_data["./"]["direct-test"] == {
@@ -270,13 +279,13 @@ def test_add_repo_invalid_config(
     ) -> None:
         """Test handling of invalid config file."""
         config_file = tmp_path / ".vcspull.yaml"
-        
+
         # Write invalid YAML
         config_file.write_text("invalid: yaml: content:", encoding="utf-8")
-        
-        # Change to tmp directory  
+
+        # Change to tmp directory
         monkeypatch.chdir(tmp_path)
-        
+
         # Try to add repo
         add_repo(
             name="test",
@@ -285,7 +294,7 @@ def test_add_repo_invalid_config(
             path=None,
             base_dir=None,
         )
-        
+
         # Should log error to stderr
         captured = capsys.readouterr()
         assert "Error loading YAML" in captured.err
@@ -297,14 +306,14 @@ def test_add_command_help(
     """Test add command help output."""
     with contextlib.suppress(SystemExit):
         cli(["add", "--help"])
-    
+
     captured = capsys.readouterr()
     output = captured.out + captured.err
-    
+
     # Check help content
     assert "Add a repository to the vcspull configuration file" in output
     assert "name" in output
     assert "url" in output
     assert "--path" in output
     assert "--dir" in output
-    assert "--config" in output
+    assert "--config" in output