Skip to content

Hotfix/socai custom header#2101

Merged
osmontero merged 2 commits into
release/v11.2.9from
hotfix/socai_customHeader
May 23, 2026
Merged

Hotfix/socai custom header#2101
osmontero merged 2 commits into
release/v11.2.9from
hotfix/socai_customHeader

Conversation

@AlexSanchez-bit
Copy link
Copy Markdown
Contributor

No description provided.

AlexSanchez-bit and others added 2 commits May 22, 2026 20:28
… config (#2092)

* fix[frontend](socai): added default template for empty previous socai configuration

* fix[frontend](socai): setted customHeaders as password key type

* fix[frontend](socai): dont let empty description on modules

* fix[backend](socai): generate the modulegroup with new keys if no other exists on db
@AlexSanchez-bit AlexSanchez-bit requested a review from a team May 22, 2026 22:05
@github-actions
Copy link
Copy Markdown

❌ Go dependencies check failed

There are outdated Go dependencies, or modules that could not be inspected.
Run bash .github/scripts/go-deps.sh --update --discover locally and
commit the updated go.mod / go.sum files.

Script output
🔍 Discovered 25 Go projects

📦 Dependencies with updates available:

  📁 ./plugins/modules-config:
     - github.com/aws/aws-sdk-go-v2/config: v1.32.17 → v1.32.18
     - github.com/aws/aws-sdk-go-v2/credentials: v1.19.16 → v1.19.17

  📁 ./plugins/aws:
     - github.com/aws/aws-sdk-go-v2/config: v1.32.17 → v1.32.18
     - github.com/aws/aws-sdk-go-v2/credentials: v1.19.16 → v1.19.17

  📁 ./agent:
     - golang.org/x/sys: v0.44.0 → v0.45.0

�[0;31m❌ Please update dependencies before merging.�[0m

@github-actions
Copy link
Copy Markdown

🛑 AI review — Engineer review required

This PR touches critical paths or introduces changes the model cannot judge with sufficient confidence. @Kbayero @osmontero please review.

🛑 architecture (gemini-3-flash-lite) — Tier 3 — engineer review required

Summary: Database schema modification via Liquibase migration and changes to sensitive configuration handling.

  • high backend/src/main/resources/config/liquibase/changelog/20260522001_update_socai_custom_headers_password.xml:1 — Introduction of a new database migration. All migrations are Tier 3 as they modify the persistent schema and require careful production rollout planning.
  • medium frontend/src/app/app-module/guides/guide-soc-ai/guide-soc-ai.component.ts:435 — Logic change in how sensitive configuration (customHeaders) is persisted and masked. Changes to secret handling and configuration persistence logic require careful validation to ensure no data loss or exposure.

⚠️ bugs (gemini-3-flash-lite) — Tier 2 — changes requested

Summary: Potential null pointer dereference in UtmModuleConfigValidator and missing null check for headerRows in hasMaskedHeaderRows.

  • medium backend/src/main/java/com/park/utmstack/domain/application_modules/validators/UtmModuleConfigValidator.java:62 — Potential NullPointerException: k.getConfKey() or k.getConfValue() could be null if the object is not fully initialized, leading to a crash during stream processing.
  • medium frontend/src/app/app-module/guides/guide-soc-ai/guide-soc-ai.component.ts:604 — Potential runtime error: this.headerRows is initialized as an empty array but could be null or undefined depending on component lifecycle; accessing .some() on it without a null check is unsafe.

⚠️ security (gemini-3-flash-lite) — Tier 2 — changes requested

Summary: Potential information disclosure of internal developer name in Liquibase changelog file.

  • medium backend/src/main/resources/config/liquibase/changelog/20260522001_update_socai_custom_headers_password.xml:8 — Internal developer name 'Alex' leaked in the changelog author attribute. Remove or replace with a generic identifier.

Copy link
Copy Markdown

@utmstackprapprover utmstackprapprover Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — see approver comments above.

@osmontero osmontero merged commit b9d2e20 into release/v11.2.9 May 23, 2026
5 of 7 checks passed
@osmontero osmontero deleted the hotfix/socai_customHeader branch May 23, 2026 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants