Skip to content

Commit cb1f42a

Browse files
Parity of Response formatter menu dropdown with Bruno app (#33) (#35)
Co-authored-by: Vineet Sharma (vasharma05) <vineet@usebruno.com>
1 parent a729bef commit cb1f42a

3 files changed

Lines changed: 17 additions & 21 deletions

File tree

packages/bruno-api-docs/src/components/Playground/Content/Views/PlaygroundView/ResponsePane/ResponseFormatter/PreviewToggleHeader/StyledWrapper.ts

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,8 @@ export const StyledWrapper = styled.div`
44
display: flex;
55
align-items: center;
66
justify-content: space-between;
7-
gap: 1.5rem;
8-
min-width: 11.875rem;
9-
padding: 0.25rem;
7+
gap: 0.75rem;
8+
padding: 0.35rem 0.625rem;
109
1110
.preview-toggle-label {
1211
font-size: 0.8125rem;
@@ -16,11 +15,11 @@ export const StyledWrapper = styled.div`
1615
.preview-toggle {
1716
position: relative;
1817
flex-shrink: 0;
19-
width: 2.125rem;
20-
height: 1.125rem;
18+
width: 2rem;
19+
height: 1rem;
2120
padding: 0;
2221
border: none;
23-
border-radius: 0.5625rem;
22+
border-radius: 1.5rem;
2423
cursor: pointer;
2524
background: var(--oc-background-surface2);
2625
transition: background 0.15s ease;
@@ -32,10 +31,10 @@ export const StyledWrapper = styled.div`
3231
3332
.preview-toggle-knob {
3433
position: absolute;
35-
top: 2px;
36-
left: 2px;
37-
width: 0.875rem;
38-
height: 0.875rem;
34+
top: 0.125rem;
35+
left: 0.125rem;
36+
width: 0.75rem;
37+
height: 0.75rem;
3938
border-radius: 50%;
4039
background: var(--oc-background-base);
4140
transition: left 0.15s ease;

packages/bruno-api-docs/src/components/Playground/Content/Views/PlaygroundView/ResponsePane/ResponseFormatter/ResponseFormatter.tsx

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,12 +52,18 @@ const ResponseFormatSelector: React.FC<ResponseFormatSelectorProps> = ({
5252
itemToText={(item: MenuDropdownItem) => (
5353
<span className="inline-flex items-center gap-1.5">
5454
{TriggerIcon && (
55-
<TriggerIcon size={14} stroke={1.5} aria-hidden data-testid="response-format-selector-trigger-icon" />
55+
<TriggerIcon
56+
size={14}
57+
stroke={1.5}
58+
aria-hidden
59+
data-testid="response-format-selector-trigger-icon"
60+
style={{ color: 'var(--oc-brand)' }}
61+
/>
5662
)}
5763
{item.label}
5864
</span>
5965
)}
60-
placement="bottom-start"
66+
placement="bottom-end"
6167
header={<PreviewToggleHeader checked={showPreview} onChange={toggleView} />}
6268
testId="response-format-selector"
6369
/>

packages/bruno-api-docs/src/ui/MenuDropdown/StyledWrapper.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -173,11 +173,6 @@ export const StyledWrapper = styled.div`
173173
margin: 0.25rem 0;
174174
}
175175
176-
.dropdown-header-container,
177-
.dropdown-footer-container {
178-
padding: 0.25rem 0.625rem;
179-
}
180-
181176
.dropdown-divider {
182177
height: 1px;
183178
background-color: var(--oc-dropdown-separator);
@@ -225,10 +220,6 @@ export const TriggerButton = styled.button`
225220
&:hover {
226221
color: var(--oc-text);
227222
}
228-
&[aria-expanded='true'] {
229-
color: var(--oc-accents-primary);
230-
border-color: var(--oc-accents-primary);
231-
}
232223
&:focus-visible {
233224
outline: 2px solid var(--oc-accents-primary);
234225
outline-offset: 1px;

0 commit comments

Comments
 (0)