Summary
Non-functional cleanups flagged during review ("worth a pass"). Tracked as a checklist, not a single runtime bug:
Efficiency
Reuse / altitude
Steps to Reproduce
By code inspection (see file references above); no runtime repro — these are perf/maintainability items.
Expected Result
Shared helpers/constants reused from a single source; per-id catalog lookups and per-exec DuckDB setup avoided; listing avoids full-file row counts and redundant list_catalog() passes.
Actual Result
Duplicated logic and redundant/synchronous work as itemized above.
Additional Information
Identified via static review of #123; low priority relative to Issues 1–4.
Summary
Non-functional cleanups flagged during review ("worth a pass"). Tracked as a checklist, not a single runtime bug:
Efficiency
get_datasetcalls fulllist_catalog()twice (for include_hub in (True,False)) —catalog_listing.py:232auto_install(full file copy) on the/processPythonCoderesponse pathget_catalog_diris an O(N) manifest scan per idlist_itemslazily counts full CSV/GeoJSON rows inside the listing requestworker.py:222Reuse / altitude
relativeTime/datasetCount/formatBytescopied 4× (exported indatasetDetailHelpers.ts)KIND_TO_FORMATvsSANDBOX_DATATYPE_TO_FORMAT; format→extension maps in 3 places; junk-label denylist in 3 placespublish_datasethand-rolled id regex vsDATASET_DIR_REprovenance.is_catalogable_outputis areturn Truestub gated on as if it filtersbuildOutputRefsreimplementsbuildSaveableLiveOutputsSteps to Reproduce
By code inspection (see file references above); no runtime repro — these are perf/maintainability items.
Expected Result
Shared helpers/constants reused from a single source; per-id catalog lookups and per-exec DuckDB setup avoided; listing avoids full-file row counts and redundant
list_catalog()passes.Actual Result
Duplicated logic and redundant/synchronous work as itemized above.
Additional Information
Identified via static review of #123; low priority relative to Issues 1–4.