SignColumn and CursorLineSign

[pkazmier]

Both SignColumn and CursorLineSign have explicit backgrounds defined (core). This is problematic with floating windows that have a sign column as the backgrounds do not match. For example:

If I remove the explicit background for SignColumn and CursorLineSign, then it looks as I would expect:

I tried several variants and I did not see any negative consequences in non-floating windows, but I'm not familiar with all the use cases that might have led to defining a bg explicitly.Thoughts?

[uhs-robert]

Good observations! There was no good reason to have a background here. Personally, I am not too familiar with when these two highlight groups are used, so I opted for bg.core. I did not realize they could appear in Floats.

I will go ahead and remove the background for both of these 👍🏻